Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: make menu item height using default value #318

Merged
merged 1 commit into from
Jan 8, 2024
Merged

bugfix: make menu item height using default value #318

merged 1 commit into from
Jan 8, 2024

Conversation

phlpsong
Copy link
Collaborator

@phlpsong phlpsong commented Jan 7, 2024

Remove increaseMenuItemHeight func to use default menu item height

Screenshot 2024-01-07 at 21 47 36

@tisfeng
Copy link
Owner

tisfeng commented Jan 8, 2024 •
edited
Loading

由于菜单项目前使用的系统的 SF 图片，不方便通过修改 size 的方式来修改高度 #316 (comment) ，因此改为默认高度。

@tisfeng tisfeng merged commit 9433ee3 into tisfeng:dev Jan 8, 2024
5 checks passed
@tisfeng tisfeng mentioned this pull request Jan 8, 2024
Merged
@phlpsong phlpsong deleted the phlpsong/menu_item_height branch January 8, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisfeng tisfeng tisfeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phlpsong @tisfeng