-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Defaults
package into project and implement Setting - General with SwiftUI
#323
Conversation
… options in SwiftUI Setting View
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello CanglongCl, Thank you for your first PR contribution 🎉 CanglongCl
I'm not sure how the project store other type in original storage. To use |
EZLanguage can be rewritten with Swift, however I am not sure if this would affect the objc code that use EZLanguage, as it is used in many places. If other objc code will not be affected, then EZLanguage can be rewritten directly. If there is an impact, many places will have to make corresponding changes, which may be a lot of work. Overall, I am in favor of rewriting EZLanguage with Swift. |
BTW I think this PR can be just merged. Other related migration can be based on |
Defaults
package into project and implement boolean options in Setting - General SwiftUI ViewDefaults
package into project and implement Setting - General with SwiftUI
close #287