add disabled app list tab

[phlpsong]

close #289

After a lot of research, I found that the selection highlight style could not customized(with multi selection gesture support) due to SwiftUI's limitation.

Any questions or suggestions about this, please let me know.

[Jerry23011]

I think it looks very nice, finally made it through all the tabs in Settings 🎉

Just some notes here:

• My system is in Simplified Chinese, why is Keychain Access.app displayed in English

• There seem to be an almost unnoticeable lag for the list to appear when switching from Service tab to Disabled app list tab

2024-01-18.19.04.04.mov

[CanglongCl]

close #289

After a lot of research, I found that the selection highlight style could not customized(with multi selection gesture support) due to SwiftUI's limitation.

Any questions or suggestions about this, please let me know.

There's indeed no easy solution for it if you are using List(selection). If it need more customization, use List() and detect with selectedItems.contain(item) instead

[phlpsong]

I think it looks very nice, finally made it through all the tabs in Settings 🎉

Just some notes here:

• My system is in Simplified Chinese, why is Keychain Access.app displayed in English

* There seem to be an almost unnoticeable lag for the list to appear when switching from Service tab to Disabled app list tab

2024-01-18.19.04.04.mov

Thanks for your comments.

First issue fixed in 502a346

About the second issue I will take a look at it later. The odd behavior happens when service tab switch to others tab, I think root cause is the frame size change.

[phlpsong]

close #289
After a lot of research, I found that the selection highlight style could not customized(with multi selection gesture support) due to SwiftUI's limitation.
Any questions or suggestions about this, please let me know.

There's indeed no easy solution for it if you are using List(selection). If it need more customization, use List() and detect with selectedItems.contain(item) instead

Yes, I have thought about this before, but we will lose the quick multi selection ability after that. Maybe we could discuss and decide which one is more important.

[phlpsong]

@Jerry23011 The lag issue disappears in the latest commit. You may check it.

[Jerry23011]

Yes indeed, both of them are gone. Thank you

…

2024年1月18日 22:46，phlpsong ***@***.***> 写道： @Jerry23011 <https://github.com/Jerry23011> The lag issue disappears in the latest commit. You may double check it. — Reply to this email directly, view it on GitHub <#340 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVHRTBMANSAUMSZKJKCXOL3YPIJDNAVCNFSM6AAAAABCBIPZTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJZHA2TMMRQGY>. You are receiving this because you were mentioned.

[tisfeng]

It looks great, but there are two small issues that need to be fixed:

1. Adding a disabled App by dragging it causes a very noticeable lag.
2. As for adding and removing disabled App controls, I prefer the previous segmented style, it's more obvious and clearer.

In addition, the current Add and Remove buttons do not have clear enough colors, there should be some contrast directly between the enabled and disabled states of the buttons, which needs to be improved by referring to the previous buttons.

[tisfeng]

If there is no suitable system color, we can add one ourselves, as long as it achieves the effect we want.

I referred to the system settings page and added an add & minus background color and list border color, it looks good.

[phlpsong]

@tisfeng yep, I did tried add the same color with system table bg, but not look harmonized.

I think your changes look good.

[phlpsong]

@tisfeng Could you describe the detail of the lag issue? Or we can merge this now and open an issue to track it separately? I could dive deep into it later.

[tisfeng]

Looks good, let's merge it.