Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature alter #425

Merged
merged 16 commits into from
Feb 26, 2024
Merged

Feature alter #425

merged 16 commits into from
Feb 26, 2024

Conversation

AkaShark
Copy link
Collaborator

closed #345

@Jerry23011
Copy link
Collaborator

Jerry23011 commented Feb 25, 2024 •
edited
Loading

I also fixed a typo in the previous codebase

tisfeng
tisfeng requested changes Feb 25, 2024
View reviewed changes
Easydict/App/Localizable.xcstrings Outdated Show resolved Hide resolved
phlpsong
phlpsong requested changes Feb 25, 2024
View reviewed changes
Easydict/App/Localizable.xcstrings Outdated Show resolved Hide resolved
Easydict/App/Localizable.xcstrings Outdated Show resolved Hide resolved
@AkaShark AkaShark requested review from phlpsong and tisfeng February 25, 2024 03:38
@phlpsong
Copy link
Collaborator

phlpsong commented Feb 25, 2024 •
edited
Loading

After clear the shortcuts keys, There is one alert popup while I tried to set the key Option + D to Select Text to Translate

Screenshot 2024-02-25 at 12 03 39

Could you kindly confirm if it's an issue?

@tisfeng
Copy link
Owner

tisfeng commented Feb 25, 2024 •
edited
Loading

After clear the shortcuts keys, There is one alert popup while I tried to set the key Option + D to Select Text to Translate

Screenshot 2024-02-25 at 12 03 39 Could you kindly confirm if it's an issue?

Similar to this issue #192 , you can refer to the idea of 0fe84d1 to fix it.

@AkaShark
Copy link
Collaborator Author

okay, I will fix later

@tisfeng tisfeng mentioned this pull request Feb 26, 2024
Closed
4 tasks
@AkaShark AkaShark requested a review from phlpsong February 26, 2024 14:19
@AkaShark
Copy link
Collaborator Author

After clear the shortcuts keys, There is one alert popup while I tried to set the key Option + D to Select Text to Translate

Screenshot 2024-02-25 at 12 03 39 Could you kindly confirm if it's an issue?

Fix this in other PR

phlpsong
phlpsong previously approved these changes Feb 26, 2024
View reviewed changes
@AkaShark AkaShark requested review from tisfeng and phlpsong February 26, 2024 15:29
tisfeng
tisfeng approved these changes Feb 26, 2024
View reviewed changes
Copy link
Owner

@tisfeng tisfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tisfeng tisfeng merged commit ff5c7a1 into tisfeng:dev Feb 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phlpsong phlpsong phlpsong approved these changes

@tisfeng tisfeng tisfeng approved these changes

@NeverAgain11 NeverAgain11 Awaiting requested review from NeverAgain11

@choykarl choykarl Awaiting requested review from choykarl

@CanglongCl CanglongCl Awaiting requested review from CanglongCl

@Jerry23011 Jerry23011 Awaiting requested review from Jerry23011

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AkaShark @Jerry23011 @phlpsong @tisfeng