Feature alter

Easydict/App/Localizable.xcstrings

@@ -1451,7 +1451,7 @@
         "zh-Hans" : {
           "stringUnit" : {
             "state" : "translated",
-            "value" : "请确保已设置了触发 Easydict 的快捷！\n\n如需恢复，请在查词窗口使用快捷键 `Cmd + ,` 打开设置页，然后取消【隐藏菜单栏图标】选项。"
+            "value" : "请确保已设置了触发 Easydict 的快捷键！\n\n如需恢复，请在查词窗口使用快捷键 `Cmd + ,` 打开设置页，然后取消【隐藏菜单栏图标】选项。"
           }
         }
       }
@@ -1775,7 +1775,7 @@
         },
         "zh-Hans" : {
           "stringUnit" : {
-            "state" : "needs_review",
+            "state" : "translated",
             "value" : "反馈"
           }
         }
@@ -2334,6 +2334,23 @@
         }
       }
     },
+    "refuse_hide_menu_bar_icon_msg" : {
+      "extractionState" : "manual",
+      "localizations" : {
+        "en" : {
+          "stringUnit" : {
+            "state" : "translated",
+            "value" : "Now Detected that there is not set input translation shortcut key or selection translation shortcut key!\n\nSet the shortcut key to make sure you can go Easydict and hide the menu bar icon."
+          }
+        },
+        "zh-Hans" : {
+          "stringUnit" : {
+            "state" : "translated",
+            "value" : "检测到当前未设置输入翻译快捷键或划词翻译快捷键!\n\n请先设置快捷键确保可以触发 Easydict 再隐藏菜单栏图标"
+          }
+        }
+      }
+    },
     "replace_text" : {
       "localizations" : {
         "en" : {

Easydict/Feature/PerferenceWindow/EZSettingViewController.m

@@ -1021,6 +1021,17 @@ - (void)showAppleDictionaryQuickLinkButtonClicked:(NSButton *)sender {
 
 
 - (void)hideMenuBarIconButtonClicked:(NSButton *)sender {
+    // if user not set select shortcut and input shortcut not allow hidden menu bar icon
+    if (self.selectionShortcutView.shortcutValue == nil &&
+        self.inputShortcutView.shortcutValue == nil) {
+        sender.mm_isOn = NO;
+        NSAlert *alert = [[NSAlert alloc] init];
+        [alert addButtonWithTitle:NSLocalizedString(@"ok", nil)];
+        alert.messageText = NSLocalizedString(@"hide_menu_bar_icon", nil);
+        alert.informativeText = NSLocalizedString(@"refuse_hide_menu_bar_icon_msg", nil);
+        [alert beginSheetModalForWindow:[self window] completionHandler:nil];
+        return;
+    }
     // !!!: EZFloatingWindowLevel shouldn't be higher than kCGModalPanelWindowLevel (8)
     if (sender.mm_isOn) {
         NSAlert *alert = [[NSAlert alloc] init];

Easydict/NewApp/View/SettingView/Tabs/GeneralTab.swift

@@ -12,7 +12,6 @@ import SwiftUI
 @available(macOS 13, *)
 struct GeneralTab: View {
     @Environment(\.colorScheme) var colorScheme
-
     var body: some View {
         Form {
             Section {
@@ -137,7 +136,17 @@ struct GeneralTab: View {
                 Toggle(isOn: $hideMainWindow) {
                     Text("hide_main_window")
                 }
-                Toggle(isOn: $hideMenuBarIcon) {
+                Toggle(isOn: $hideMenuBarIcon.didSet(execute: { state in
+                    if state {
+                        // user is not set input shortcut and selection shortcut not allow hide menu bar
+                        if !detectSetShortcutStatus {
+                            Defaults[.hideMenuBarIcon] = false
+                            showRefuseAlert = true
+                        } else {
+                            showHideMenuBarIconAlert = true
+                        }
+                    }
+                })) {
                     Text("hide_menu_bar_icon")
                 }
                 Picker(
@@ -155,6 +164,25 @@ struct GeneralTab: View {
             }
         }
         .formStyle(.grouped)
+        .alert("hide_menu_bar_icon", isPresented: $showRefuseAlert) {
+            Button("ok") {
+                showRefuseAlert = false
+            }
+        } message: {
+            Text("refuse_hide_menu_bar_icon_msg")
+        }
+        .alert("hide_menu_bar_icon", isPresented: $showHideMenuBarIconAlert) {
+            HStack {
+                Button("ok") {
+                    showHideMenuBarIconAlert = false
+                }
+                Button("cancel") {
+                    Defaults[.hideMenuBarIcon] = false
+                }
+            }
+        } message: {
+            Text("hide_menu_bar_icon_msg")
+        }
     }
 
     @Default(.autoSelectText) private var autoSelectText
@@ -197,6 +225,19 @@ struct GeneralTab: View {
 
     @Default(.fontSizeOptionIndex) private var fontSizeOptionIndex
     @Default(.selectedMenuBarIcon) private var selectedMenuBarIcon
+
+    private var detectSetShortcutStatus: Bool {
+        if Defaults[.inputShortcut] == nil,
+           Defaults[.selectionShortcut] == nil
+        {
+            false
+        } else {
+            true
+        }
+    }
+
+    @State private var showRefuseAlert: Bool = false
+    @State private var showHideMenuBarIconAlert = false
 }
 
 @available(macOS 13, *)