Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eudic2 detect #454 #455

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Add eudic2 detect #454 #455

merged 1 commit into from
Mar 14, 2024

Conversation

Roiocam
Copy link
Contributor

@Roiocam Roiocam commented Mar 13, 2024

Solve: #454

Verified it works locally.

截屏2024-03-13 16 27 44

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Roiocam, Thank you for your first PR contribution 🎉 Roiocam

@tisfeng tisfeng requested a review from Jerry23011 March 13, 2024 16:03
Copy link
Owner

@tisfeng tisfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tisfeng tisfeng merged commit e5ce53b into tisfeng:main Mar 14, 2024
5 checks passed
@Roiocam Roiocam deleted the add-eudic2-shortcut branch March 14, 2024 03:03
@phlpsong
Copy link
Collaborator

This should target to dev branch.

@tisfeng
Copy link
Owner

tisfeng commented Mar 14, 2024

I didn't notice this, but it's not a big problem. Let's just leave it like that.

@phlpsong
Copy link
Collaborator

phlpsong commented Mar 14, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants