-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Language preference #468
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choykarl
requested review from
phlpsong,
tisfeng and
CanglongCl
and removed request for
phlpsong and
tisfeng
March 22, 2024 16:27
CanglongCl
previously approved these changes
Mar 22, 2024
tisfeng
previously approved these changes
Mar 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
CanglongCl
previously approved these changes
Mar 23, 2024
phlpsong
requested changes
Mar 23, 2024
phlpsong
reviewed
Mar 23, 2024
phlpsong
requested changes
Mar 23, 2024
Easydict/Feature/ViewController/Window/BaseQueryWindow/EZBaseQueryViewController.m
Outdated
Show resolved
Hide resolved
…ueryViewController.m Co-authored-by: Phillip Song <[email protected]>
Co-authored-by: Phillip Song <[email protected]>
Co-authored-by: Phillip Song <[email protected]>
phlpsong
approved these changes
Mar 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Good review. |
tisfeng
approved these changes
Mar 23, 2024
Great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#348