Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Language preference #468

Merged
merged 12 commits into from
Mar 24, 2024
Merged

App Language preference #468

merged 12 commits into from
Mar 24, 2024

Conversation

choykarl
Copy link
Collaborator

@choykarl choykarl commented Mar 22, 2024

@choykarl choykarl requested review from phlpsong, tisfeng and CanglongCl and removed request for phlpsong and tisfeng March 22, 2024 16:27
CanglongCl
CanglongCl previously approved these changes Mar 22, 2024
@tisfeng tisfeng requested review from AkaShark and Jerry23011 March 23, 2024 03:40
tisfeng
tisfeng previously approved these changes Mar 23, 2024
Copy link
Owner

@tisfeng tisfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@choykarl choykarl dismissed stale reviews from tisfeng and CanglongCl via 1a43d30 March 23, 2024 04:00
@choykarl choykarl requested review from CanglongCl and tisfeng March 23, 2024 04:07
CanglongCl
CanglongCl previously approved these changes Mar 23, 2024
@choykarl choykarl requested a review from phlpsong March 23, 2024 07:23
@choykarl choykarl requested a review from phlpsong March 23, 2024 09:15
Copy link
Collaborator

@phlpsong phlpsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@choykarl choykarl requested a review from CanglongCl March 23, 2024 11:58
@tisfeng
Copy link
Owner

tisfeng commented Mar 23, 2024

Good review.

@tisfeng tisfeng merged commit a86f56c into tisfeng:dev Mar 24, 2024
5 checks passed
@tisfeng
Copy link
Owner

tisfeng commented Mar 24, 2024

Great job!

@choykarl choykarl deleted the language_preference2 branch March 24, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants