Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tsql): remove BEGIN from identifiers #4695

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

geooo109
Copy link
Collaborator

@geooo109 geooo109 commented Feb 3, 2025

BEGIN is a reserved keyword in TSQL, thus it can't be used as an identifier of any purpose.
This PR removes the usage of BEGIN for this occasion.

Moreover, this PR removes the INTERVAL_VARS from the base Parser class because it isn't needed any more.

DOCS
T-SQL BEGIN

tests/dialects/test_tsql.py Outdated Show resolved Hide resolved
@georgesittas georgesittas merged commit 1904b76 into main Feb 3, 2025
7 checks passed
@georgesittas georgesittas deleted the geooo109/tsql_remove_begin_from_id_vars branch February 3, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants