Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mobile): mobile experimental feature setting #8922

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Nov 26, 2024

close AF-1802

CleanShot 2024-11-26 at 10.02.27.gif

Copy link

graphite-app bot commented Nov 26, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added mod:infra Environment related issues and discussions mod:component app:core labels Nov 26, 2024
Copy link
Member Author

CatsJuice commented Nov 26, 2024

@CatsJuice CatsJuice force-pushed the catsjuice/feat/mobile-feature-flag-setting branch 2 times, most recently from de7c1c2 to b6f7b6b Compare November 26, 2024 01:59
@CatsJuice CatsJuice force-pushed the catsjuice/feat/mobile-feature-flag-setting branch from b6f7b6b to 0c8cad3 Compare November 26, 2024 02:01
@CatsJuice CatsJuice marked this pull request as ready for review November 26, 2024 02:02
@CatsJuice CatsJuice force-pushed the catsjuice/feat/mobile-feature-flag-setting branch from 0c8cad3 to bfc18fc Compare November 26, 2024 02:04
@CatsJuice CatsJuice force-pushed the catsjuice/feat/mobile-feature-flag-setting branch from bfc18fc to a036cf8 Compare November 26, 2024 02:07
@CatsJuice CatsJuice force-pushed the catsjuice/feat/mobile-feature-flag-setting branch from a036cf8 to e2882bc Compare November 26, 2024 02:11
Copy link

nx-cloud bot commented Nov 26, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 71ab75e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 65.30%. Comparing base (c95e6ec) to head (71ab75e).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...ckages/frontend/component/src/ui/switch/switch.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8922      +/-   ##
==========================================
+ Coverage   64.74%   65.30%   +0.55%     
==========================================
  Files         664      664              
  Lines       37338    37343       +5     
  Branches     3607     3647      +40     
==========================================
+ Hits        24176    24387     +211     
+ Misses      12795    12586     -209     
- Partials      367      370       +3     
Flag Coverage Δ
server-test 77.84% <ø> (+0.71%) ⬆️
unittest 34.58% <60.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Nov 28, 2024

Merge activity

@CatsJuice CatsJuice force-pushed the catsjuice/feat/mobile-feature-flag-setting branch from e2882bc to 71ab75e Compare November 28, 2024 07:25
@graphite-app graphite-app bot merged commit 71ab75e into canary Nov 28, 2024
46 checks passed
@graphite-app graphite-app bot deleted the catsjuice/feat/mobile-feature-flag-setting branch November 28, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:component mod:infra Environment related issues and discussions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants