Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mobile): a basic swipeable dialog for setting #8923

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Nov 26, 2024

CleanShot 2024-12-02 at 15.42.42.gif

Copy link

graphite-app bot commented Nov 26, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

CatsJuice commented Nov 26, 2024

Copy link

nx-cloud bot commented Nov 26, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4744896. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.68%. Comparing base (9b4cd83) to head (4744896).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8923      +/-   ##
==========================================
- Coverage   65.24%   64.68%   -0.57%     
==========================================
  Files         664      664              
  Lines       37344    37344              
  Branches     3648     3611      -37     
==========================================
- Hits        24366    24156     -210     
- Misses      12607    12820     +213     
+ Partials      371      368       -3     
Flag Coverage Δ
server-test 77.07% <ø> (-0.72%) ⬇️
unittest 34.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice force-pushed the catsjuice/feat/nested-swipe-dialog branch from 8f20023 to b0dba94 Compare November 26, 2024 05:05
@CatsJuice CatsJuice force-pushed the catsjuice/feat/nested-swipe-dialog branch from b0dba94 to 0b55270 Compare November 26, 2024 05:11
@CatsJuice CatsJuice changed the base branch from catsjuice/feat/mobile-feature-flag-setting to graphite-base/8923 November 28, 2024 07:25
@CatsJuice CatsJuice force-pushed the catsjuice/feat/nested-swipe-dialog branch from 0b55270 to 5c18919 Compare November 28, 2024 07:41
@CatsJuice CatsJuice changed the base branch from graphite-base/8923 to canary November 28, 2024 07:42
@CatsJuice CatsJuice force-pushed the catsjuice/feat/nested-swipe-dialog branch from 5c18919 to 044d17e Compare November 28, 2024 07:42
@graphite-app graphite-app bot requested review from EYHN, forehalo and JimmFly December 2, 2024 07:43
Copy link
Collaborator

@pengx17 pengx17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐂🍺

Copy link

graphite-app bot commented Dec 2, 2024

Merge activity

@EYHN EYHN force-pushed the catsjuice/feat/nested-swipe-dialog branch from 935a64a to 4744896 Compare December 2, 2024 08:42
@graphite-app graphite-app bot merged commit 4744896 into canary Dec 2, 2024
46 checks passed
@graphite-app graphite-app bot deleted the catsjuice/feat/nested-swipe-dialog branch December 2, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants