Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected the A+B+C.zip file naming convention #8

Open
wants to merge 3 commits into
base: 2.0
Choose a base branch
from

Conversation

anoopemacs
Copy link

Fixes #7

@@ -31,8 +31,10 @@ Whenever you sync with the server, a file with the format `{date in GMT}={X}+{Y}
{date in GMT}={B}+{Y}.zip

**Resulting transaction file**
Because `date in GMT of the oldest` < `date in GMT of the youngest`,
{date in GMT}={X}+{Y}+{Z}.zip
Resulting transaction file Based on alphabetical order, say if `X < Y`, then: {date in GMT}={X}+{Y}+{Z}.zip
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to confirm through experiment that is indeed the case?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes,
date in GMT of the oldest < date in GMT of the youngest OR
date in GMT of the oldest > date in GMT of the youngest
has no effect on resulting file name

Because `date in GMT of the oldest` < `date in GMT of the youngest`,
{date in GMT}={X}+{Y}+{Z}.zip
Resulting transaction file Based on alphabetical order, say if `X < Y`, then: {date in GMT}={X}+{Y}+{Z}.zip
Hence, in all P+Q+R.zip type filenames, alphabetically `P < Q`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems incomplete.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner

@tomzx tomzx Oct 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only found one example going through those links, but I'll assume it's a better assumption than the initial one.

However, what I was saying is that this sentence is incomplete (furthermore, it appears to repeat what was said just above).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the duplicate now
but, why incomplete?

Resulting transaction file Based on alphabetical order, say if `X < Y`, then: {date in GMT}={X}+{Y}+{Z}.zip
Hence, in all P+Q+R.zip type filenames, alphabetically `P < Q`

Any transaction file generated next will henceforth be named {date in GMT}={Z}+{C}.zip, where Z is the randomId generated for the resulting transaction file.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a duplicate of the line just below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants