Add publish artifacts step to GitHub Actions workflow #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank @lahma for your contributions 🥇 |
totpero
added
the
detection improvements
|
@totpero Thanks for the release of 6.4.1, seems that nuget.org doesn't have symbols though, could you please also upload the snupkg there? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the published NuGet package still had problems: https://nuget.info/packages/DeviceDetector.NET/6.3.3
Adding artifacts collection to GitHub action that allows to download properly built package for NuGet publish (both nupkg and snupkg should be published to NuGet.org).
Now if you download the artifacts from build summary: https://github.com/totpero/DeviceDetector.NET/actions/runs/10267431264?pr=82
NuGet package explorer gives all checks as green: