extract the save area #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
|
bjorn3
approved these changes
Jan 14, 2025
libbz2-rs-sys/src/bzlib.rs
Outdated
| @@ -579,7 +579,6 @@ pub(crate) struct SaveArea { | |||
| pub es: i32, | |||
| pub N: i32, | |||
| pub curr: i32, | |||
| pub zt: i32, | |||
There was a problem hiding this comment.
👍 also unused in the original C code.
There was a problem hiding this comment.
yeah, I'm really not sure what is happening there.
There was a problem hiding this comment.
as in, why would they leave that field around if it's unused
There was a problem hiding this comment.
My guess would be that it was used in the past and the compiler didn't give a warning when it became unused due to the store/restore dance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and give a bunch of fields a smaller type. Can be reviewed commit-by-commit.
This PR brings a minor reduction in instructions, and no other performance changes.