Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract the save area #75

Merged
merged 7 commits into from
Jan 14, 2025
+129 −182
Merged

extract the save area #75

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
285f5e7
split out the save area
folkertdev Jan 13, 2025
1d78e35
make `gSel` and friends a `u8`
folkertdev Jan 13, 2025
228fec6
remove the unused `zt` field
folkertdev Jan 13, 2025
2500ef8
make `minLens` a `[u8; 6]`
folkertdev Jan 13, 2025
456d29d
remove a loop
folkertdev Jan 13, 2025
231c0ee
cleanup the callsite of `create_decode_table`
folkertdev Jan 13, 2025
306ad94
work around a clippy warning
folkertdev Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion libbz2-rs-sys/src/bzlib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,6 @@ pub(crate) struct SaveArea {
pub es: i32,
pub N: i32,
pub curr: i32,
pub zt: i32,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 also unused in the original C code.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I'm really not sure what is happening there.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as in, why would they leave that field around if it's unused

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess would be that it was used in the past and the compiler didn't give a warning when it became unused due to the store/restore dance.

pub zn: i32,
pub zvec: i32,
pub zj: i32,
Expand Down
2 changes: 0 additions & 2 deletions libbz2-rs-sys/src/decompress.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,6 @@ pub(crate) fn decompress(
mut es,
mut N,
mut curr,
zt,
mut zn,
mut zvec,
mut zj,
Expand Down Expand Up @@ -1343,7 +1342,6 @@ pub(crate) fn decompress(
es,
N,
curr,
zt,
zn,
zvec,
zj,
Expand Down