Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nil pointer evaluating interface #180

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Conversation

fl0-m
Copy link
Member

@fl0-m fl0-m commented Jun 3, 2024

Upgrading to 0.23.0, I get this error

Error: template: trino/templates/ingress.yaml:33:25: executing "trino/templates/ingress.yaml" at <include "trino.fullname" .>: error calling include: template: trino/templates/_helpers.tpl:15:14: executing "trino.fullname" at <.Values.fullnameOverride>: nil pointer evaluating interface {}.fullnameOverride
helm.go:84: [debug] template: trino/templates/ingress.yaml:33:25: executing "trino/templates/ingress.yaml" at <include "trino.fullname" .>: error calling include: template: trino/templates/_helpers.tpl:15:14: executing "trino.fullname" at <.Values.fullnameOverride>: nil pointer evaluating interface {}.fullnameOverride

This PR aims to fix nil pointer evaluating interface, by using $, which references the global scope in order to access the Values as expected.

@cla-bot cla-bot bot added the cla-signed label Jun 3, 2024
@fl0-m
Copy link
Member Author

fl0-m commented Jun 3, 2024

@nineinchnick 👋 PTAL

Copy link
Member

@nineinchnick nineinchnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same fix was suggested in #179. I'm inclined to merge this first since you have the CLA signed, and I could release a new version quicker.

@nineinchnick
Copy link
Member

Can you also add a test, so we can avoid regressions like this in future?

@fl0-m
Copy link
Member Author

fl0-m commented Jun 3, 2024

Sure

@fl0-m
Copy link
Member Author

fl0-m commented Jun 3, 2024

@nineinchnick PTAL

@nineinchnick nineinchnick merged commit d5104a7 into trinodb:main Jun 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants