bug: tio can run without NATS or ETCD #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanolson
previously approved these changes
Feb 18, 2025
grahamking
requested review from
rmccorm4,
tanmayv25,
ptarasiewiczNV,
ishandhanani,
alec-flowers,
nnshah1 and
nv-anants
as code owners
grahamking
force-pushed
the
gk-offline-tio
branch
from
6fd5ede to
c991f0b
Compare
Previously `tio` wouldn't run unless etcd and nats were present in the environment, even though it doesn't use them yet. This makes it easier to use `tio`.
grahamking
force-pushed
the
gk-offline-tio
branch
from
688cd23 to
5c21c70
Compare
rmccorm4
approved these changes
Feb 18, 2025
rmccorm4
reviewed
Feb 18, 2025
Comment on lines
+80
to
+82
| //let dt_config = triton_distributed::distributed::DistributedConfig::from_settings(); | ||
| // Wraps the Runtime (which wraps two tokio runtimes) and adds etcd and nats clients | ||
| let d_runtime = triton_distributed::DistributedRuntime::new(runtime, dt_config).await?; | ||
| //let d_runtime = triton_distributed::DistributedRuntime::new(runtime, dt_config).await?; |
There was a problem hiding this comment.
Can you elaborate a bit on the implications of this? For example, with the distributed_runtime included, would you be able to hook up components exposed run by tio with llmctl or other tooling, and with these commented out, would they no longer be discoverable? Looking for high level ideas to learn more about how the moving parts relate to each other
There was a problem hiding this comment.
There are no implications. We were creating a DistributedRuntime but not using any parts of it.
Currently there are no components and no discovery. Once we start doing out=nats we will want the distributed runtime, so I left it in commented out.
There was a problem hiding this comment.
Makes sense, thanks Graham!
ryanolson
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
tiowouldn't run unless etcd and nats were present in the environment, even though it doesn't use them yet.This makes it easier to use
tio.