Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: tio can run without NATS or ETCD #203

Merged
merged 1 commit into from
Feb 18, 2025
+3 −9
Merged

bug: tio can run without NATS or ETCD #203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions applications/llm/bin/tio/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,15 +77,9 @@ async fn tio_wrapper(runtime: triton_distributed::Runtime) -> anyhow::Result<()>

// etcd and nats addresses, from env vars ETCD_ENDPOINTS and NATS_SERVER with localhost
// defaults
let dt_config = triton_distributed::distributed::DistributedConfig::from_settings();
//let dt_config = triton_distributed::distributed::DistributedConfig::from_settings();
// Wraps the Runtime (which wraps two tokio runtimes) and adds etcd and nats clients
let d_runtime = triton_distributed::DistributedRuntime::new(runtime, dt_config).await?;
//let d_runtime = triton_distributed::DistributedRuntime::new(runtime, dt_config).await?;
Comment on lines +80 to +82
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate a bit on the implications of this? For example, with the distributed_runtime included, would you be able to hook up components exposed run by tio with llmctl or other tooling, and with these commented out, would they no longer be discoverable? Looking for high level ideas to learn more about how the moving parts relate to each other

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no implications. We were creating a DistributedRuntime but not using any parts of it.

Currently there are no components and no discovery. Once we start doing out=nats we will want the distributed runtime, so I left it in commented out.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks Graham!


tio::run(
in_opt,
out_opt,
nio_flags,
d_runtime.runtime().primary_token(),
)
.await
tio::run(in_opt, out_opt, nio_flags, runtime.primary_token()).await
}
Loading