Navier-Stokes 1D #1597
Merged
Navier-Stokes 1D #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1597 +/- ##
===========================================
+ Coverage 84.97% 96.30% +11.33%
===========================================
Files 402 405 +3
Lines 33046 33250 +204
===========================================
+ Hits 28078 32020 +3942
+ Misses 4968 1230 -3738
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jlchan
requested changes
Aug 7, 2023
There was a problem hiding this comment.
It doesn't look like the 1D parabolic boundary conditions are tested anywhere. Would it be possible to modify this elixir to be non-periodic?
There was a problem hiding this comment.
Should be, I can try the y-direction from the 2D example to test wall & adiabatic BCs.
ranocha
reviewed
Aug 8, 2023
Comment on lines
280
to
330
| """ | ||
| struct BoundaryConditionNavierStokesWall | ||
|
|
||
| Creates a wall-type boundary conditions for the compressible Navier-Stokes equations. | ||
| The fields `boundary_condition_velocity` and `boundary_condition_heat_flux` are intended | ||
| to be boundary condition types such as the `NoSlip` velocity boundary condition and the | ||
| `Adiabatic` or `Isothermal` heat boundary condition. | ||
|
|
||
| !!! warning "Experimental feature" | ||
| This is an experimental feature and may change in future releases. | ||
| """ | ||
| struct BoundaryConditionNavierStokesWall{V, H} | ||
| boundary_condition_velocity::V | ||
| boundary_condition_heat_flux::H | ||
| end | ||
|
|
||
| """ | ||
| struct NoSlip | ||
|
|
||
| Use to create a no-slip boundary condition with `BoundaryConditionNavierStokesWall`. The field `boundary_value_function` | ||
| should be a function with signature `boundary_value_function(x, t, equations)` | ||
| and should return a `SVector{NDIMS}` whose entries are the velocity vector at a | ||
| point `x` and time `t`. | ||
| """ | ||
| struct NoSlip{F} | ||
| boundary_value_function::F # value of the velocity vector on the boundary | ||
| end | ||
|
|
||
| """ | ||
| struct Isothermal | ||
|
|
||
| Used to create a no-slip boundary condition with [`BoundaryConditionNavierStokesWall`](@ref). | ||
| The field `boundary_value_function` should be a function with signature | ||
| `boundary_value_function(x, t, equations)` and return a scalar value for the | ||
| temperature at point `x` and time `t`. | ||
| """ | ||
| struct Isothermal{F} | ||
| boundary_value_function::F # value of the temperature on the boundary | ||
| end | ||
|
|
||
| """ | ||
| struct Adiabatic | ||
|
|
||
| Used to create a no-slip boundary condition with [`BoundaryConditionNavierStokesWall`](@ref). | ||
| The field `boundary_value_normal_flux_function` should be a function with signature | ||
| `boundary_value_normal_flux_function(x, t, equations)` and return a scalar value for the | ||
| normal heat flux at point `x` and time `t`. | ||
| """ | ||
| struct Adiabatic{F} | ||
| boundary_value_normal_flux_function::F # scaled heat flux 1/T * kappa * dT/dn | ||
| end |
There was a problem hiding this comment.
Aren't these structs already defined in the file for the 2D system? Since the structs are generic, could we please move them to another file - maybe src/equations/compressible_navier_stokes.jl?
There was a problem hiding this comment.
Yes and no - I moved them from 2D to 1D for now. Adding a seperate file src/equations/compressible_navier_stokes.jl is a more expressive way, I think
Comment on lines
96
to
112
| """ | ||
| !!! warning "Experimental code" | ||
| This code is experimental and may be changed or removed in any future release. | ||
|
|
||
| `GradientVariablesPrimitive` and `GradientVariablesEntropy` are gradient variable type parameters | ||
| for `CompressibleNavierStokesDiffusion1D`. By default, the gradient variables are set to be | ||
| `GradientVariablesPrimitive`. Specifying `GradientVariablesEntropy` instead uses the entropy variable | ||
| formulation from | ||
| - Hughes, Mallet, Franca (1986) | ||
| A new finite element formulation for computational fluid dynamics: I. Symmetric forms of the | ||
| compressible Euler and Navier-Stokes equations and the second law of thermodynamics. | ||
| [https://doi.org/10.1016/0045-7825(86)90127-1](https://doi.org/10.1016/0045-7825(86)90127-1) | ||
|
|
||
| Under `GradientVariablesEntropy`, the Navier-Stokes discretization is provably entropy stable. | ||
| """ | ||
| struct GradientVariablesPrimitive end | ||
| struct GradientVariablesEntropy end |
|
So I adapted the non-periodic direction from the 2D example. For this, I had to add Convergence of the example: |
jlchan
requested changes
Aug 8, 2023
examples/tree_1d_dgsem/elixir_navierstokes_convergence_walls.jl
Outdated
Show resolved
Hide resolved
jlchan
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1147
Convergence study: