-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix old API usage for Camera3D #1940
Fix old API usage for Camera3D #1940
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot. Please find below a question.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## compathelper/new_version/2024-05-10-00-05-49-190-02195501927 #1940 +/- ##
================================================================================================
- Coverage 91.16% 86.38% -4.78%
================================================================================================
Files 453 453
Lines 36457 36450 -7
================================================================================================
- Hits 33233 31486 -1747
- Misses 3224 4964 +1740
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
17d8c2e
into
trixi-framework:compathelper/new_version/2024-05-10-00-05-49-190-02195501927
cc @ranocha - this should fix the issue.