Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix old API usage for Camera3D #1940

Merged
merged 4 commits into from
May 13, 2024
Merged

Fix old API usage for Camera3D #1940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c7dfadc
Fix old API usage for Camera3D
asinghvi17 May 10, 2024
4acdf79
Update Project.toml
asinghvi17 May 13, 2024
9061e8e
Update Project.toml
asinghvi17 May 13, 2024
05a41bd
Update Project.toml
asinghvi17 May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ LinearAlgebra = "1"
LinearMaps = "2.7, 3.0"
LoopVectorization = "0.12.151"
MPI = "0.20"
Makie = "0.19, 0.20, 0.21"
Makie = "0.20, 0.21"
MuladdMacro = "0.2.2"
Octavian = "0.3.21"
OffsetArrays = "1.12"
Expand Down
2 changes: 1 addition & 1 deletion docs/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Trixi2Vtk = "bc1476a1-1ca6-4cc3-950b-c312b255ff95"
TrixiBase = "9a0f1c46-06d5-4909-a5a3-ce25d3fa3284"

[compat]
CairoMakie = "0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12"
CairoMakie = "0.11, 0.12"
Changelog = "1.1"
Documenter = "1"
ForwardDiff = "0.10"
Expand Down
2 changes: 1 addition & 1 deletion ext/TrixiMakieExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ function iplot(pd::PlotData2DTriangulated;

# On OSX, shift-command-4 for screenshots triggers a constant "up-zoom".
# To avoid this, we remap up-zoom to the right shift button instead.
Makie.cameracontrols(ax.scene).attributes[:up_key][] = Makie.Keyboard.right_shift
Makie.cameracontrols(ax.scene).controls[:up_key][] = Makie.Keyboard.right_shift

# typing this pulls up the figure (similar to display(plot!()) in Plots.jl)
fig
Expand Down
2 changes: 1 addition & 1 deletion test/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

[compat]
Aqua = "0.8"
CairoMakie = "0.10, 0.12"
CairoMakie = "0.11, 0.12"
Downloads = "1"
ExplicitImports = "1.0.1"
FFMPEG = "0.4"
Expand Down
Loading