Add numerical support of other real types (ideal)

[huiyuxie]

Continue #1909.

Tasks:

• ideal_glm_mhd 1d, 2d, 3d
• unit tests for above

[github-actions]

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

• The PR has a single goal that is clear from the PR title and/or description.
• All code changes represent a single set of modifications that logically belong together.
• No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

• The code can be understood easily.
• Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
• There are no redundancies that can be removed by simple modularization/refactoring.
• There are no leftover debug statements or commented code sections.
• The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

• New functions and types are documented with a docstring or top-level comment.
• Relevant publications are referenced in docstrings (see example for formatting).
• Inline comments are used to document longer or unusual code sections.
• Comments describe intent ("why?") and not just functionality ("what?").
• If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

• The PR passes all tests.
• New or modified lines of code are covered by tests.
• New or modified tests run in less then 10 seconds.

Performance

• There are no type instabilities or memory allocations in performance-critical parts.
• If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

• The correctness of the code was verified using appropriate tests.
• If new equations/methods are added, a convergence test has been run and the results
  are posted in the PR.

Created with ❤️ by the Trixi.jl community.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.19%. Comparing base (179854e) to head (19f22ec).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1984      +/-   ##
==========================================
+ Coverage   96.16%   96.19%   +0.03%     
==========================================
  Files         460      460              
  Lines       36984    36993       +9     
==========================================
+ Hits        35564    35584      +20     
+ Misses       1420     1409      -11     

Flag	Coverage Δ
unittests	96.19% <100.00%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[huiyuxie]

Ready for final review and merge @ranocha ^^

[ranocha]

Thanks a lot!

[ranocha]

Hmm, the CI test failures seem to be related to this PR - they fail for all of the Alfven wave setups:

• https://github.com/trixi-framework/Trixi.jl/actions/runs/9729676500/job/26851829955?pr=1984#step:7:4587
• https://github.com/trixi-framework/Trixi.jl/actions/runs/9729676500/job/26851830031?pr=1984#step:7:16143
• https://github.com/trixi-framework/Trixi.jl/actions/runs/9729676500/job/26851830188?pr=1984#step:7:6103

We should find out what's going wrong. I didn't spot any obvious problems when reviewing the code.

[huiyuxie]

Thanks! Please give me some time to look into those errors.

[huiyuxie]

Wow looks like it is fixed now ^^ that's amazing! Please check my comments above since I don't know why those integers cannot be Float32 - for me, they all passed the type tests.

[ranocha]

Thanks!