Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Covariant formulation of the shallow water equations #58

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

tristanmontoya
Copy link
Member

@tristanmontoya tristanmontoya commented Dec 23, 2024

New version of #37 with entropy-stable split forms and auxiliary variables. Requires Trixi.jl v0.9.9 (see #59). The following new features are implemented:

  • New equation type CovariantShallowWaterEquations2D which implements the split formulation of the covariant derivative using non-conservative terms, but does not use non-conservative terms for the standard formulation. The split formulation conserves total energy when no interface dissipation is added.
  • Non-conservative flux-differencing and interface flux kernels for the covariant form using auxiliary variables.
  • Auxiliary variables expanded to include more geometric information, including Christoffel symbols (which, for the moment, are computed by applying the LGL collocation derivative operator to the analytical metric tensor components). Note that the split formulation is provably stable regardless of how these geometric terms are computed.
  • Analysis routines for covariant-form equations take integrals of functions of the form func(u, aux_vars, equations) rather than just func(u, equations), which is needed since entropy is a function of auxiliary variables in this case.
  • Standardized initial conditions with automatic conversions to the chosen global coordinate system (i.e. Cartesian or spherical) and set of conservative variables. Currently, we have the Gaussian solid-body rotation, steady geostrophic balance, and Rossby-Haurwitz wave, based on Cases 1, 2, and 5 of the Williamson et al. test suite, respectively.

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 93.09211% with 21 lines in your changes missing coverage. Please review.

Project coverage is 90.04%. Comparing base (fd639d6) to head (9021899).

Files with missing lines Patch % Lines
src/equations/covariant_shallow_water.jl 91.45% 10 Missing ⚠️
src/equations/covariant_advection.jl 37.50% 5 Missing ⚠️
src/equations/shallow_water_3d.jl 0.00% 4 Missing ⚠️
src/equations/equations.jl 97.36% 1 Missing ⚠️
...vers/dgsem_p4est/dg_2d_manifold_in_3d_covariant.jl 98.38% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   89.46%   90.04%   +0.58%     
==========================================
  Files          20       21       +1     
  Lines        1803     2079     +276     
==========================================
+ Hits         1613     1872     +259     
- Misses        190      207      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant