-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Covariant formulation of the shallow water equations #58
Draft
tristanmontoya
wants to merge
17
commits into
main
Choose a base branch
from
tm/new_shallow_water
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/new_shallow_water
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
==========================================
+ Coverage 89.46% 90.04% +0.58%
==========================================
Files 20 21 +1
Lines 1803 2079 +276
==========================================
+ Hits 1613 1872 +259
- Misses 190 207 +17 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of #37 with entropy-stable split forms and auxiliary variables. Requires Trixi.jl v0.9.9 (see #59). The following new features are implemented:
CovariantShallowWaterEquations2D
which implements the split formulation of the covariant derivative using non-conservative terms, but does not use non-conservative terms for the standard formulation. The split formulation conserves total energy when no interface dissipation is added.func(u, aux_vars, equations)
rather than justfunc(u, equations)
, which is needed sinceentropy
is a function of auxiliary variables in this case.