Compatibility with Trixi.jl v0.9.9+ (Remove unused surface_integral from calls to prolong2mortars!)
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristanmontoya
changed the title
surface_integral from calls to prolong2mortars!)surface_integral from calls to prolong2mortars!)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
=======================================
Coverage 89.46% 89.46%
=======================================
Files 20 20
Lines 1803 1803
=======================================
Hits 1613 1613
Misses 190 190 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Cartesian solver defines a specialized
rhs!which no longer worked with Trixi.jl v0.9.9 and up, since it passed the unusedsurface_integralintoprolong2mortars!, which is no longer accepted due to trixi-framework/Trixi.jl#2188. This PR simply removes that parameter, which was not used anyway. The compat entry in Project.toml should therefore be changed from 0.9 to 0.9.9.