-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lots of optics #79
Draft
b-mehta
wants to merge
3
commits into
master
Choose a base branch
from
lots-of-optics
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Lots of optics #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-mehta
force-pushed
the
lots-of-optics
branch
from
September 12, 2019 15:21
19b4cdc
to
b7c4c3f
Compare
b-mehta
force-pushed
the
lots-of-optics
branch
from
September 13, 2019 08:41
b7c4c3f
to
a7e68fc
Compare
I've modified the |
b-mehta
force-pushed
the
lots-of-optics
branch
from
September 13, 2019 09:33
fb9226d
to
0d5029f
Compare
aspiwack
added a commit
that referenced
this pull request
Sep 18, 2020
These are ported from #79 where they were needed for traversal-type things. These instances can't hurt. Even though I don't know what we are going to do with traversals yet.
aspiwack
added a commit
that referenced
this pull request
Sep 18, 2020
These are ported from #79 where they were needed for traversal-type things. These instances can't hurt. Even though I don't know what we are going to do with traversals yet.
aspiwack
added a commit
that referenced
this pull request
Sep 18, 2020
With a linear lens, we cannot linearly set the value at the lens site in general, however, we can swap the value at the lens site for another, which we get out of the operation. Ported from #79.
aspiwack
added a commit
that referenced
this pull request
Sep 18, 2020
Translation between the profunctor definition of lens and the more straightforward getter/setter pair. Ported from #79.
This was referenced Sep 18, 2020
Merged
I've pushed most of this PR to smaller PRs (#194 , #195, #196 ). What's left is
I'm leaving the PR open, still, as an inspiration as I'm trying to tackle the traversal story. See also #190 (and soon more). |
utdemir
pushed a commit
that referenced
this pull request
Sep 22, 2020
With a linear lens, we cannot linearly set the value at the lens site in general, however, we can swap the value at the lens site for another, which we get out of the operation. Ported from #79.
utdemir
pushed a commit
that referenced
this pull request
Sep 22, 2020
Translation between the profunctor definition of lens and the more straightforward getter/setter pair. Ported from #79.
utdemir
pushed a commit
that referenced
this pull request
Sep 22, 2020
With a linear lens, we cannot linearly set the value at the lens site in general, however, we can swap the value at the lens site for another, which we get out of the operation. Ported from #79.
utdemir
pushed a commit
that referenced
this pull request
Sep 22, 2020
Translation between the profunctor definition of lens and the more straightforward getter/setter pair. Ported from #79.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft:
:*:
is flipped, and the<*>
definition adjusted accordingly.set, set', set''
might not be useful.withXXX
functions aren't consistent in their return type.MyFunctor
andinn
.