Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When recursively dumping the content of an ext2 filesystem where extended attribute value conflicts with key using
rdump / /tmp/out
, debugfs get's in an endless loop.This is due to the fact that we only break out of the while(1) loop if the 'got' value is 0, which never happens when an error is encountered.
The applied fix mimics what happens when retval is non-zero and returns.
This can be tested with an existing test sample from e2fsprogs (see
tests/f_ea_value_crash/image.gz
).Behavior prior to this patch: