Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debugfs: fix endless loop in rdump #149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

qkaiser
Copy link

@qkaiser qkaiser commented Jun 14, 2023

When recursively dumping the content of an ext2 filesystem where extended attribute value conflicts with key using rdump / /tmp/out, debugfs get's in an endless loop.

This is due to the fact that we only break out of the while(1) loop if the 'got' value is 0, which never happens when an error is encountered.

The applied fix mimics what happens when retval is non-zero and returns.

This can be tested with an existing test sample from e2fsprogs (see tests/f_ea_value_crash/image.gz).

Behavior prior to this patch:

$ mkdir -p /tmp/out
$ gunzip tests/f_ea_value_crash/image.gz
$ ./debugfs/debugfs -R 'rdump / /tmp/out' tests/f_ea_value_crash/image
debugfs 1.47.0 (5-Feb-2023)
rdump: Extended attribute has an invalid value offset while reading ext2 file
rdump: Extended attribute has an invalid value offset while reading ext2 file
rdump: Extended attribute has an invalid value offset while reading ext2 file
rdump: Extended attribute has an invalid value offset while reading ext2 file
--endless loop here--

…ribute value conflicts with key.

When recursively dumping the content of an ext2 filesystem where
extended attribute value conflicts with key using "rdump / /tmp/out ",
debugfs get's in an endless loop.

This is due to the fact that we only break out of the while(1) loop if
the 'got' value is 0, which never happens when an error is encountered.

The applied fix mimics what happens when retval is non-zero and returns.

This can be tested with an existing test sample
(tests/f_ea_value_crash/image.gz).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant