fix non android gradle instructions #467
Conversation
resolves GH#466
|
|
| @@ -23,15 +23,17 @@ plugins { | |||
| } | |||
|
|
|||
| dependencies { | |||
| annotationProcessor "com.uber.nullaway:nullaway:0.9.1" | |||
| errorprone("com.uber.nullaway:nullaway:0.9.1") | |||
There was a problem hiding this comment.
Should we also update the suggested version of net.ltgt.errorprone while we are at it? I noticed the latest version is 2.0.1, so maybe 0.6 is quite old now
There was a problem hiding this comment.
Also, lower down where it says "the annotationProcessor line loads NullAway", that should also be changed to "the first errorprone line" or something like that
There was a problem hiding this comment.
yeah, that version is ancient, honestly I didn't really notice, or worry about fixing that, but maybe that's why this was written this way. Maybe the better change would just be to point to the plugin's documentation as it actually covers all of this... let me know if you'd rather I do it that way.
| @@ -73,7 +75,7 @@ Snapshots of the development version are available in [Sonatype's snapshots repo | |||
|
|
|||
| The configuration for an Android project is very similar to the Java case, with one key difference: The `com.google.code.findbugs:jsr305:3.0.2` dependency can be removed; you can use the `android.support.annotation.Nullable` annotation from the Android Support library. | |||
|
|
|||
| ```gradle | |||
| ``` | |||
There was a problem hiding this comment.
you know, I don't actually know how this happened, I'm questioning whether githubs web editor removed it, as an unrecognized extension, really it should probably be groovy or kts
|
Sorry for not circling back to this PR for a bit. Fixing it up requires a bit of thought and I haven't had time. I do plan to circle back when I have more cycles, hopefully in the next couple of weeks or so |
|
@xenoterracide I finally got around to fixing up the docs in #843. Sorry for the huge delay, and thanks again for the contribution here. |
resolves #466