Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making a few protected functions public for raw file ingestion #125

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

AlbertSnows
Copy link
Contributor

@AlbertSnows AlbertSnows commented Jun 24, 2024

This PR makes a few protected functions public as these functions are going to be used in an automation process we use to generate PFBs.

Link to JIRA ticket if there is one:

New Features

Breaking Changes

Bug Fixes

Improvements

Dependency updates

Deployment changes

@AlbertSnows AlbertSnows marked this pull request as ready for review July 2, 2024 19:51
@AlbertSnows AlbertSnows changed the title [DNM] Making a few protected functions public to run the ingestion process Making a few protected functions public for raw file ingestion Jul 2, 2024
Copy link

@jacob50231 jacob50231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of these function name changes look alright and it looks like you changed the name every time the function is called elsewhere. Approving but feel free to still wait for feedback!

Copy link
Member

@MichaelLukowski MichaelLukowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty small changes,

looks good to me

@AlbertSnows AlbertSnows merged commit f4e0354 into master Jul 5, 2024
5 checks passed
@AlbertSnows AlbertSnows deleted the publicize_pfb_protected_functions branch July 5, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants