Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jcs/txn report #411

Merged
merged 10 commits into from
Mar 11, 2024
Merged

Jcs/txn report #411

merged 10 commits into from
Mar 11, 2024

Conversation

jSylvestre
Copy link
Member

No description provided.

@jSylvestre jSylvestre marked this pull request as ready for review March 8, 2024 23:39
@jSylvestre jSylvestre requested a review from a team as a code owner March 8, 2024 23:39
@jSylvestre
Copy link
Member Author

Issue #410

Copy link
Contributor

@sprucely sprucely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test, but code looks good.

Sloth.Web/Sloth.Web.csproj Outdated Show resolved Hide resolved
@@ -163,6 +163,8 @@ public string FullObjectToString()
}
return result;
}

public string ShortFinancialSegmentString => $"{FinancialSegmentString?[0..13]}...";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never seen this w/o using string.substr() but if this works it's ok to me. clear enough what's happening.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it takes the first 13 characters of the string. I'll add a comment

@jSylvestre jSylvestre merged commit 3be2cd7 into master Mar 11, 2024
5 checks passed
@jSylvestre jSylvestre deleted the JCS/TxnReport branch March 11, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants