Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.springframework.boot:spring-boot-starter-parent from 2.7.8 to 3.1.3 #106

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 25, 2023

Bumps org.springframework.boot:spring-boot-starter-parent from 2.7.8 to 3.1.3.

Release notes

Sourced from org.springframework.boot:spring-boot-starter-parent's releases.

v3.1.3

🐞 Bug Fixes

  • Logging config URLs with query parameters are not detected as XML #37062
  • Changed environment variable name APP_PASSWORD to APP_USER_PASSWORD i? #37044
  • BindableRuntimeHintsRegistrar does not generate hints for all nested types of a ConfigurationProperties type #37022
  • server.max-http-request-header-size doesn't affect Netty server with http2 enabled #37015
  • AbstractAotMojo should not add source or target if they are null #36972
  • Exception message in ProcessTestAotMojo has a typo #36966
  • Docker Compose start fails with "unknown flag: --no-color" #36908
  • Script-based database initialization fails with an unhelpful error message when configured with a resource that points to a directory #36786
  • Artemis ConnectionFactory is not configured when CachingConnectionFactory is missing and enabled properties are false #36772
  • DatabaseDriver swallows real exception #36759
  • Defining a custom ElasticsearchTransport causes the auto-configured JsonpMapper to back off #36700
  • Auto-configuration's session repository customization may override that of SessionRepositoryCustomizer beans #36696
  • RabbitMQ smoke test is missing a test #36612
  • Tomcat warns about a missing +/- prefix when enabling multiple protocols through server.ssl.enabled-protocols #36584
  • management.metrics.export.stackdriver properties are incomplete #36559
  • management.wavefront.metrics.export properties are incomplete #36556
  • management.metrics.export.signalfx properties are incomplete #36553
  • JobLauncherApplicationRunner returns a success exit code even when no jobs have been run #36532
  • Remove use of jakarta.annotation.PostConstruct #36529
  • management.metrics.export.atlas properties are incomplete #36526
  • Descriptions of started and ready time metrics contain time units but the unit may change when the metrics are exported #36516
  • Unlike other Spring Boot goals, process-aot and process-test-aot run on Maven reactor projects #36494
  • @ServiceConnection on a @Bean method does not work in sliced tests #36037

📔 Documentation

  • Fix broken links in the documentation #37071
  • Maven plugin docs contain invalid parameter for image building #37051
  • Align javadoc of AbstractFilterRegistrationBean#setDispatcherTypes #36969
  • Improve documentation of spring.cache.type=none #36962
  • Clarify that spring.security.filter properties only apply to servlet-based web apps #36865
  • Improve documentation to describe how @EntityScan and @Enable?Repositories can be used to tune scanning #36862
  • Describe quirks of JUL and Log4j2 in the javadoc of OutputCaptureExtension #36859
  • LogbackLoggingSystem does not report suppressed exception details #36856
  • Clarify table that shows how logging properties are transferred to system properties #36853
  • Review Google AppEngine documentation #36850
  • Rework Working with NoSQL Technologies to clarify which stores are supported by Spring Data #36813
  • Clarify how nested directories are treated for configtree with wildcards #36810
  • Clarify the effect of using @EnableWebMvc #36797
  • Document defaults for spring.mvc.format.* and spring.webflux.format.* properties #36793
  • Documentation describes how to opt in to using the path pattern parser but it's now the default #36789
  • Document that scripts for database initialization are optional by default and how they can be made mandatory #36783
  • Document @DataR2dbcTest support #36756
  • @since is missing from javadoc of values added to JavaVersion since its introduction #36735
  • Update Paketo builder references in documentation #36690
  • Document how to use Docker Compose integration when running tests #36636
  • Update RestTemplateBuilder#defaultHeader javadoc to reference correct client-side HTTP request class #36630

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [org.springframework.boot:spring-boot-starter-parent](https://github.com/spring-projects/spring-boot) from 2.7.8 to 3.1.3.
- [Release notes](https://github.com/spring-projects/spring-boot/releases)
- [Commits](spring-projects/spring-boot@v2.7.8...v3.1.3)

---
updated-dependencies:
- dependency-name: org.springframework.boot:spring-boot-starter-parent
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@joshbaskaran
Copy link
Contributor

Assuming the auth error gets fixed for GH Actions, This PR introduced quite a few changes and bring it up to speed with the current standards along with updating to Spring boot 3. The following significant changes have been made:

  • Converted all field injections to constructor injections
  • Converted deprecated WebSecurityConfigurerAdapter's configure function to the now recommended SecurityFilterChain. Also follows a newer function chaining syntax
  • Replaces deprecated code up the updated API's where ever needed.

Given that these may not be 1:1 changes, we should run the E2E test first before merging.

@joshbaskaran joshbaskaran linked an issue Sep 4, 2023 that may be closed by this pull request
@kjellp
Copy link
Contributor

kjellp commented Sep 13, 2023

e2e test did not pass wilth all other service being latest (seems to be issue with CEGA auth), but that could be that the rewrite in this branch changed a previous mechanism for the test to avoid CEGA NSS on upload). I will try to test also with my different setup (not using that additional mechanism, but the regular CEGA NSS auth):

2023-09-13 05:50:04.187  INFO 1 --- [nio-8080-exec-6] no.uio.ifi.ltp.aspects.AAIAspect         : Cannot invoke "no.uio.ifi.ltp.dto.ResultsHolder.getCredentials()" because the return value of "no.uio.ifi.ltp.dto.ResponseHolder.getResultsHolder()" is null

java.lang.NullPointerException: Cannot invoke "no.uio.ifi.ltp.dto.ResultsHolder.getCredentials()" because the return value of "no.uio.ifi.ltp.dto.ResponseHolder.getResultsHolder()" is null
	at no.uio.ifi.ltp.authentication.CEGACredentialsProvider.getCredentials(CEGACredentialsProvider.java:53) ~[classes!/:0.0.1-SNAPSHOT]
	at no.uio.ifi.ltp.authentication.CEGACredentialsProvider$$FastClassBySpringCGLIB$$1e644983.invoke(<generated>) ~[classes!/:0.0.1-SNAPSHOT]
	at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218) ~[spring-core-5.3.17.jar!/:5.3.17]
	at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:783) ~[spring-aop-5.3.17.jar!/:5.3.17]
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163) ~[spring-aop-5.3.17.jar!/:5.3.17]
	at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:753) ~[spring-aop-5.3.17.jar!/:5.3.17]
	at org.springframework.cache.interceptor.CacheInterceptor.lambda$invoke$0(CacheInterceptor.java:54) ~[spring-context-5.3.17.jar!/:5.3.17]
	at org.springframework.cache.interceptor.CacheAspectSupport.invokeOperation(CacheAspectSupport.java:366) ~[spring-context-5.3.17.jar!/:5.3.17]
	at org.springframework.cache.interceptor.CacheAspectSupport.execute(CacheAspectSupport.java:421) ~[spring-context-5.3.17.jar!/:5.3.17]
	at org.springframework.cache.interceptor.CacheAspectSupport.execute(CacheAspectSupport.java:345) ~[spring-context-5.3.17.jar!/:5.3.17]
	at org.springframework.cache.interceptor.CacheInterceptor.invoke(CacheInterceptor.java:64) ~[spring-context-5.3.17.jar!/:5.3.17]
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186) ~[spring-aop-5.3.17.jar!/:5.3.17]
	at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:753) ~[spring-aop-5.3.17.jar!/:5.3.17]
	at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:698) ~[spring-aop-5.3.17.jar!/:5.3.17]
	at no.uio.ifi.ltp.authentication.CEGACredentialsProvider$$EnhancerBySpringCGLIB$$7af5990.getCredentials(<generated>) ~[classes!/:0.0.1-SNAPSHOT]
	at no.uio.ifi.ltp.aspects.AAIAspect.cegaAuth(AAIAspect.java:126) ~[classes!/:0.0.1-SNAPSHOT]
	at no.uio.ifi.ltp.aspects.AAIAspect.authenticateCEGA(AAIAspect.java:113) ~[classes!/:0.0.1-SNAPSHOT]

@kjellp
Copy link
Contributor

kjellp commented Sep 13, 2023

The StackTrace above is from the proxy server log (not the e2e test code stack trace).

When testing the service on the tryggve server, using regular EGA username/password and ELIXIR_AAI_TOKEN, and run the new e2e test in a docker container from the tryggve server, I get the same stack trace in PROXY_proxy logs... So there seems to be something not working for real.

@Parisa68
Copy link
Collaborator

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 22, 2023

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 25, 2023

A newer version of org.springframework.boot:spring-boot-starter-parent exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@joshbaskaran
Copy link
Contributor

Already done and merged in.

Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 8, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/maven/org.springframework.boot-spring-boot-starter-parent-3.1.3 branch November 8, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update localega-tsd-proxy to springboot 3
3 participants