Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include a check for quant.sf file #143

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Include a check for quant.sf file #143

merged 1 commit into from
Mar 14, 2024

Conversation

skanwal
Copy link
Member

@skanwal skanwal commented Mar 14, 2024

Closes #137

Tested using both salmon and dragen_wts_dir directory locally.

@skanwal skanwal requested a review from pdiakumis March 14, 2024 03:48
pdiakumis
pdiakumis approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@pdiakumis pdiakumis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
So if neither of the salmon files are found, that salmon becomes NULL.

@skanwal skanwal merged commit 01d556d into rnasum-rpackage Mar 14, 2024
1 check passed
@skanwal skanwal deleted the update-quant-reading branch March 14, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdiakumis pdiakumis pdiakumis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skanwal @pdiakumis