-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rnasum input parameters #480
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following should be removed:
clinical_info
clinical_id
hide_code_btn
grch_version
Following should be added:
dragen_mapping_metrics
Following are in the arguments
but not the inputs (not sure if adding them in the inputs makes sense but just saying):
batch_rm
filter
log
@pdiakumis - updated in |
Tested on ICA with wfr.08d375cb7c24428185142ba8a6b1cb38 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, LGTM
@@ -95,7 +90,7 @@ inputs: | |||
type: File? | |||
inputBinding: | |||
prefix: "--arriba_tsv" | |||
umccrise_directory: | |||
umccrise: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for changing this :-)
Ah yes, that's my bad. We need to wait for GH actions to complete before merging in the PRs in this repo. |
Can't reopen a PR but I've restored the branch, reran GH actions, have added 0.5.0 version to production_workflows project with |
Updating inputs to bring it at par with the current state of https://github.com/umccr/RNAsum/tree/rnasum-rpackage.
I'll create a new tag that would refer to docker image once we have completed the tests in dev.