Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rnasum input parameters #480

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Update rnasum input parameters #480

merged 3 commits into from
Apr 5, 2024

Conversation

skanwal
Copy link
Member

@skanwal skanwal commented Apr 4, 2024

Updating inputs to bring it at par with the current state of https://github.com/umccr/RNAsum/tree/rnasum-rpackage.

I'll create a new tag that would refer to docker image once we have completed the tests in dev.

@skanwal skanwal requested a review from pdiakumis April 4, 2024 02:33
Copy link
Member

@pdiakumis pdiakumis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following should be removed:

  • clinical_info
  • clinical_id
  • hide_code_btn
  • grch_version

Following should be added:

  • dragen_mapping_metrics

Following are in the arguments but not the inputs (not sure if adding them in the inputs makes sense but just saying):

  • batch_rm
  • filter
  • log

@skanwal
Copy link
Member Author

skanwal commented Apr 5, 2024

@pdiakumis - updated in e9d5eec (#480). Also moved arguments to params and assigned defaults values too.

@skanwal
Copy link
Member Author

skanwal commented Apr 5, 2024

Tested on ICA with wfr.08d375cb7c24428185142ba8a6b1cb38

Copy link
Member

@pdiakumis pdiakumis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM

@@ -95,7 +90,7 @@ inputs:
type: File?
inputBinding:
prefix: "--arriba_tsv"
umccrise_directory:
umccrise:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for changing this :-)

@skanwal skanwal merged commit 5754733 into main Apr 5, 2024
5 of 6 checks passed
@skanwal skanwal deleted the update-rnasum-params branch April 5, 2024 02:23
@pdiakumis
Copy link
Member

@skanwal @alexiswl the Actions are erroring out with:

Error: couldn't find remote ref update-rnasum-params

I take it the PR shouldn't have been merged straight after approval, correct?

@skanwal
Copy link
Member Author

skanwal commented Apr 5, 2024

Ah yes, that's my bad. We need to wait for GH actions to complete before merging in the PRs in this repo.
@alexiswl - should I reopen the PR?

@alexiswl alexiswl restored the update-rnasum-params branch April 7, 2024 10:20
@alexiswl
Copy link
Member

alexiswl commented Apr 7, 2024

@alexiswl - should I reopen the PR?

Can't reopen a PR but I've restored the branch, reran GH actions, have added 0.5.0 version to production_workflows project with cwl-ica add-tool-to-project --project production_workflows --tool-path tools/rnasum/0.5.0/rnasum__0.5.0.cwl and have pushed that in #481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants