Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: path-based locations #285

Open
wants to merge 4 commits into
base: refactor/advanced-config
Choose a base branch
from

Conversation

mmalenic
Copy link
Member

Closes #281
Depends on #284

Features

  • Add a simple path-based way to writing location lists that includes file://, s3:// or http(s)://.
    *The first part of the location determines the storage, and everything in the path after determines the prefix which matches on ids. For example, s3://bucket/prefix says to find files in bucket when the request also contains the prefix - /reads/prefix/.
    • Locations can be specified as either a single location, or a list of locations with [].
    • The regex-style of specifying locations is still available. Config that is considered "advanced" is separated into a module, which is reflected in the docs.
  • Paths are joined with Pathbuf rather than string formating, so config values like file://data/path and file://data/path/ are equivalent.

Docs

  • Re-worked docs to include simplified locations first, with "advanced" config included later.

@mmalenic mmalenic self-assigned this Dec 18, 2024
@mmalenic mmalenic added the enhancement New feature or request label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant