Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deny unknown fields in config #290

Merged
merged 3 commits into from
Jan 6, 2025
Merged

feat: deny unknown fields in config #290

merged 3 commits into from
Jan 6, 2025

Conversation

mmalenic
Copy link
Member

@mmalenic mmalenic commented Jan 6, 2025 •
edited
Loading

Closes #228
Depends on #289

Changes

  • Denies all unknown fields in config by using #[serde(deny_unknown_fields)].

@mmalenic mmalenic self-assigned this Jan 6, 2025
@mmalenic mmalenic added the enhancement New feature or request label Jan 6, 2025
@mmalenic mmalenic changed the base branch from feat/error-no-config to main January 6, 2025 00:28
@mmalenic mmalenic requested a review from brainstorm January 6, 2025 00:28
@mmalenic mmalenic enabled auto-merge January 6, 2025 00:28
brainstorm
brainstorm approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@brainstorm brainstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rings-a-bell PR :P :P

@mmalenic mmalenic added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit a5af714 Jan 6, 2025
5 checks passed
@brainstorm brainstorm deleted the fix/deny-unknown-fields branch January 24, 2025 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brainstorm brainstorm brainstorm approved these changes

Assignees

@mmalenic mmalenic

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(config): reject unknown config options outright
2 participants
@mmalenic @brainstorm