chore: v6.7.0 stable release upgrade handler #2622
Conversation
WalkthroughThe pull request updates the changelog and release notes to reflect the stable release of version 6.7.0, replacing the previous release candidate version 6.7.0-rc1. It includes updates to various dependencies and addresses specific bug fixes. Additionally, the upgrade registration in the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
RELEASE_NOTES.md (2)
Line range hint
24-26: Consider adding Price Feeder version verification step.While the Price Feeder update requirement is noted, it would be helpful to add a command for users to verify they're running the correct version.
Consider adding:
Update Price Feeder to `umee/2.4.4+`. + +To verify your Price Feeder version: +```shell +price-feeder version +``` NOTE: after the upgrade, you should restart your Price Feeder. We observed that Price Feeder doesn't correctly re-establish a connection after the chain upgrade.
Line range hint
28-34: Consider adding libwasmvm version verification step.While the libwasmvm update instructions are comprehensive, adding a verification step would help users confirm they have the correct version installed.
Consider adding:
You don't need to do anything if you are using our Docker image. + +To verify your libwasmvm version: +```shell +ldd $(which umeed) | grep wasmvm +``` +The output should show `libwasmvm.$(uname -m).so => /usr/lib/libwasmvm.$(uname -m).so`app/upgrades.go (1)
57-57: Consider adding upgrade documentation.While the upgrade handler is correctly implemented, consider adding inline documentation to describe:
- The purpose of this upgrade (RC to stable transition)
- Any specific actions nodes need to take during the upgrade
Example documentation:
+ // v6.7.0 upgrades the network from release candidate to stable version + // No store upgrades or migrations are needed app.registerUpgrade("v6.7.0", upgradeInfo, nil, nil, nil)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (3)
CHANGELOG.md(1 hunks)RELEASE_NOTES.md(2 hunks)app/upgrades.go(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- CHANGELOG.md
🔇 Additional comments (3)
RELEASE_NOTES.md (2)
Line range hint 9-21: LGTM! Version and highlights are well documented.
The version update and dependency changes are clearly documented with specific version numbers, making it easy for users to understand the changes in this stable release.
22-22: LGTM! Upgrade title is correctly updated.
The Cosmovisor upgrade title has been properly updated to reflect the stable version.
app/upgrades.go (1)
57-57: LGTM! Simple upgrade handler registration.
The upgrade handler for v6.7.0 is correctly registered using the registerUpgrade helper function with no store upgrades or migrations, which aligns with the PR's objective of transitioning from RC to stable release.
Let's verify the upgrade handler registration pattern matches other simple upgrades:
✅ Verification successful
Upgrade handler registration follows consistent pattern
The verification confirms that the v6.7.0 upgrade handler follows the same pattern as other simple upgrades (v6.3 and v6.5), using registerUpgrade with nil parameters for store upgrades and migrations. This is appropriate for a stable release transition that doesn't require state changes.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that other simple upgrades follow the same pattern
# Expected: Similar upgrade registrations for v6.3 and v6.5
rg "registerUpgrade\(\"v6\.[357]" -A 1
Length of output: 387
gsk967
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2622 +/- ##
===========================================
- Coverage 75.38% 62.00% -13.39%
===========================================
Files 100 275 +175
Lines 8025 19628 +11603
===========================================
+ Hits 6050 12171 +6121
- Misses 1589 6685 +5096
- Partials 386 772 +386
|
Description
v6.7 Stable release upgrade
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit
New Features
Bug Fixes
Documentation