Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build apps with tsup and use js files on production #579

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

BlankParticle
Copy link
Member

@BlankParticle BlankParticle commented Jul 18, 2024

What does this PR do?

Finally, our hono apps are now compiled and bundled into JS file for using in production using tsup.

Some Trivia

  • I had to remove pino as this thing doesnt work with bundled apps for some reason. We used the logger at 1 place. I have replaced it with console for the time being.
  • Removed the redundant otel Zipkin Exporter
  • Added extra scripts start:all and start:all:r to make it easier to test the built apps on local machine.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Required

  • Read Contributing Guide
  • Self-reviewed my own code
  • Tested my code in a local environment
  • Commented on my code in hard-to-understand areas
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the UnInbox Docs if changes were necessary

Copy link
Member Author

BlankParticle commented Jul 18, 2024

@BlankParticle BlankParticle marked this pull request as ready for review July 18, 2024 17:15
@BlankParticle BlankParticle requested a review from McPizza0 as a code owner July 18, 2024 17:15
@BlankParticle BlankParticle merged commit f23b8ca into main Jul 21, 2024
5 checks passed
Copy link
Member Author

Merge activity

@BlankParticle BlankParticle deleted the feat/build-process branch July 21, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants