Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setup optional OpenTelemetry #585

Merged
merged 1 commit into from
Jul 21, 2024
Merged

Conversation

BlankParticle
Copy link
Member

@BlankParticle BlankParticle commented Jul 20, 2024

What does this PR do?

Open Telemetry setup with No-op when not enabled.
fixes #507

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Required

  • Read Contributing Guide
  • Self-reviewed my own code
  • Tested my code in a local environment
  • Commented on my code in hard-to-understand areas
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the UnInbox Docs if changes were necessary

Copy link
Member Author

BlankParticle commented Jul 20, 2024

@BlankParticle BlankParticle marked this pull request as ready for review July 20, 2024 18:11
@BlankParticle BlankParticle requested a review from McPizza0 as a code owner July 20, 2024 18:11
@BlankParticle BlankParticle force-pushed the feat/centralize-hono-functions branch from b3f8965 to de45b57 Compare July 21, 2024 11:36
@BlankParticle BlankParticle changed the base branch from feat/centralize-hono-functions to main July 21, 2024 11:38
@BlankParticle BlankParticle merged commit 471e56f into main Jul 21, 2024
2 checks passed
@BlankParticle BlankParticle deleted the feat/opentelemetry branch July 21, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Setup otel log collection
2 participants