Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Fix steering PID in vehicle_controller to fix wrong steering in PurePursuit #141

Closed
hellschwalex opened this issue Dec 7, 2023 · 2 comments · Fixed by #164
Closed
Assignees
Labels

Comments

@hellschwalex
Copy link
Collaborator

Description

In Leaderboard 2 the carla vehicle seemingly reacts differently to the input steering values. For once it looks like, they inverted the steer [-1 ; 1] in the carla_control_cmd message to now steer right on negative values?? ( negative was "steer left" in Leaderboard1)

There is a PID in vehicle controller that controls the steering to smoothly instead of abruptly steer into the newly calculated steering_angle.
-> This PID is not tuned, and in fact that badly tuned, for leaderboard 2, that we can not drive with it.
-> Tuning this PID and inverting the steering for the carla comand message will hopefully finally get us to finally drive again in leaderboard 2.

Definition of Done

  • Tune Steering PID in vehicle controller, so that calculated target steering from steering Controllers (Stanley and PP) is well followed with at least 95% accuracy and no overshooting.
  • Fix the steering sign in __map_steering which also somehow tunes the PID inputvalue? why? 100% correctly steer left/right.
@hellschwalex
Copy link
Collaborator Author

We may do not need this PID since it only delays the steer input (which should be optimal from our steering controllers) so if at a given time/position a steer of 30° to the right is optimal, we should just drive at 30° right steering and not slowly go from 0 to 30°. This needs further testing as absolut steering inputs ARE POSSIBLE (tho not realistic but the simulation does not punish us for using jumpy steering inputs) BUT MAYBE the jumpy nature of this leads to more unstable trajectory following?

@hellschwalex
Copy link
Collaborator Author

Disabled the PID in vehicle controller and also the strange tuning of the calculated Steering-Inputs from the Steering Controllers. This also removed the clipping of the carla-steering-singal to -0.75 ; 0.75 to now use the full range -1 ; 1.
Vehicle_Controller should only "map" the steering-Inputs (in rad) to [-1 ; 1] and invert them (since for the carla_steering-signal right and left are just inverted from what is calculated in both controllers).
This simplifies the understanding of the signalflow for steering alot, and allows proper tuning of PurePursuit and Stanley in the future.

@hellschwalex hellschwalex linked a pull request Jan 15, 2024 that will close this issue
7 tasks
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in PAF Project Backlog Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant