Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Drive action does not comment driving results #390

Closed
JulianTrommer opened this issue Oct 29, 2024 · 0 comments · Fixed by #397
Closed

[Bug]: Drive action does not comment driving results #390

JulianTrommer opened this issue Oct 29, 2024 · 0 comments · Fixed by #397
Assignees
Labels
bug Something isn't working

Comments

@JulianTrommer
Copy link
Member

Current Behavior

The last changes to the driving action removed the commenting of the driving results to the PR.
This is due to the fact that the variable github.event_name is not a pull_request because the action is triggered with a workflow_run.

Expected Behavior

The action should check if the pr_id is present in the artifacts (since it is only written if the build action was triggered with a PR) and then post the results to the comments.

How to reproduce the issue

See the last PRs and actions.

@JulianTrommer JulianTrommer added the bug Something isn't working label Oct 29, 2024
@JulianTrommer JulianTrommer self-assigned this Oct 29, 2024
@JulianTrommer JulianTrommer added this to the Sprint 00 2024-11-04 milestone Oct 29, 2024
@JulianTrommer JulianTrommer linked a pull request Oct 30, 2024 that will close this issue
7 tasks
@ll7 ll7 closed this as completed in #397 Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant