-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Improve steering behavior in the Leaderboard Launch file #257
Comments
I tested the leaderboard and devroute with both pure pursuit only as well as stanley and pure pursuit. There seems to be no difference between Leaderboard and devroute. As explained in the Note this might have been because the devroute once was asnychronous. Now the devroute is synchronous as well. There is however another difference between the trajectories from acting-debug and those of planning. The acting-debug trajectories are interpolated to 25cm, so there are probably more individual points along the trajectory. This also lead me to a correlated bug with the pure pursuit controller: Especially with new local planner we will need to fix this. In the commit to this feature branch (f700710) I added a partial fix in the comments. However if car turns more than 90deg from wanted direction we drive the route backwards. |
From my somewhat unreliable memory: there was a time when the devroute used sensors without any noise. Back then, the input to the steering system was based on the vehicle’s deviation from the global route. This noise caused fluctuations in the control error, leading to steering overcorrection. If I understand your recent changes correctly, instead of the global trajectory appearing to shift relative to the vehicle, the desired trajectory is now anchored to the vehicle itself. This adjustment might have reduced the impact of steering overcorrection. |
Following the Note with GitBlame we find it was created at the end of last semester and didn't appear before. Also we are still driving on a global trajectory influenced by noise in kalman estimation, so there should not be a difference to when the note was created. Still I cannot find clear evidence why pure pursuit would perform worse. Also this github action ran with only pure pursuit and performed no different to others. This issue came up again because we are trying to implement local planning algorithms which will need a steering algorithm for a localized "trajectory" and early tests saw pure pursuit failing in this regard. The reason for this is the bug in code as mentioned in my first comment. I will therefore open a bug issue for the specific problem (#567). Regarding this issue we might be able to close it. With the new acting component (aka. a local planner) requirements for steering controller will change anyways and more specific issues such as the one mentioned above might arise. Still there shouldn't be worries regarding the omitment of stanley while focusing on pure pursuit. |
https://github.com/una-auxme/paf23/blob/741e9084f3988916ba963da66780404669e52644/doc/05_acting/03_steering_controllers.md?plain=1#L77-L78
The text was updated successfully, but these errors were encountered: