Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Itermediate layer data_init crash #626

Closed
Zelberor opened this issue Jan 19, 2025 · 0 comments · Fixed by #627
Closed

[Bug]: Itermediate layer data_init crash #626

Zelberor opened this issue Jan 19, 2025 · 0 comments · Fixed by #627
Assignees
Labels
bug Something isn't working perception system System Engineering

Comments

@Zelberor
Copy link
Collaborator

Zelberor commented Jan 19, 2025

Current Behavior

If self.lidar_cluster_entities_data or self.self.radar_cluster_entities_data is None:

The mapping_data_init node will crash in the publish_new_map function.

The or [] only checks if entities is None but not if self.<>_cluster_entities_data is None.

Expected Behavior

The data init does not crash and uses the entities data optionally.

Steps to Reproduce

  • Start the simulation
  • The crash only happens if the node received hero_speed AND lidar_marker_data AND radar_marker_data BEFORE it receives the <>_cluster_entities_data.

Definition of Done

No response

Testability

Difficult, because the crash depends on asynchronous behavior.

But the fix is quite simple.

Dependencies

No response

@Zelberor Zelberor added bug Something isn't working perception system System Engineering labels Jan 19, 2025
@Zelberor Zelberor moved this to 🏗 In progress in PAF Project Backlog Jan 19, 2025
@Zelberor Zelberor added this to the Sprint 05 2025-01-27 milestone Jan 19, 2025
@Zelberor Zelberor self-assigned this Jan 19, 2025
@Zelberor Zelberor linked a pull request Jan 19, 2025 that will close this issue
7 tasks
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in PAF Project Backlog Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working perception system System Engineering
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant