Make some traits pub(crate) if they are able to be made pub(crate) #4339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
requested review from
zbraniecki,
gregtatum,
nordzilla,
Manishearth and
a team
as code owners
sffc
requested review from
robertbastian
and removed request for
a team,
gregtatum and
nordzilla
Manishearth
previously approved these changes
Nov 20, 2023
|
Going to land #4204 first and fix up the merge conflicts in this direction. |
sffc
force-pushed
the
pub-crate-traits
branch
from
0e93226 to
bed0ef8
Compare
Manishearth
previously approved these changes
Nov 21, 2023
robertbastian
previously approved these changes
Nov 27, 2023
Manishearth
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be more careful with
pub traits. To help a little bit I went through and found somepub traitthat could bepub(crate) traitand marked them as such. Follow-ups in #4338.