Refactor signal connections and set theme override to null #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes `Callable(self, function_name)` in favor of just `function_name`, which is way clear and more readable
juliohq
changed the title
artism90
requested changes
Sep 3, 2023
There was a problem hiding this comment.
We have a Utils class in res://Assets/World/Utils.gd for static functions. You can append those for signals there and update all references accordingly.
res://Utils/ is supposed to store macros for repititive or tedious tasks in the editor (EditorScript classes).
Co-authored-by: Arthur S. Muszynski <[email protected]>
Co-authored-by: Arthur S. Muszynski <[email protected]>
artism90
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some errors related to signals (already connected signal errors) by adding a new
SignalUtilsclass with two static functions:ensure_connected(checks if the signal is already connected before trying to connect it) andensure_disconnected(checks if the signal is not connected before trying to disconnect it). That way, there is no need to check manually if a given signal is connected to a given callable before connecting/disconnecting, which leads to clearer code.On top of that, I've replaced
Callable(self, function_name)by justfunction_namegiven it's clearer and Godot will be able to throw errors in the editor before you run the game, in case you made a typo.