Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor signal connections and set theme override to null #118

Merged
merged 8 commits into from
Sep 4, 2023
Merged

Refactor signal connections and set theme override to null #118

merged 8 commits into from
Sep 4, 2023

Commits on Sep 3, 2023

  1. Remove Callable(self, function_name) 

    Removes `Callable(self, function_name)` in favor of just `function_name`, which is way clear and more readable
    @juliohq
    juliohq committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    6b45505 View commit details
    Browse the repository at this point in the history

  2. Fix setting theme overrides to null

    @juliohq
    juliohq committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    38ea85d View commit details
    Browse the repository at this point in the history

  3. Fix signal already connected errors

    @juliohq
    juliohq committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    1c1b2bc View commit details
    Browse the repository at this point in the history

  4. Fix misunderstanding signal already connected error

    @juliohq
    juliohq committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    7290b2c View commit details
    Browse the repository at this point in the history

  5. Replace remaining is_connected checks

    @juliohq
    juliohq committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    66f1c0b View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. Remove redundant line 

    Co-authored-by: Arthur S. Muszynski <[email protected]>
    @juliohq @artism90
    juliohq and artism90 authored Sep 4, 2023
    Configuration menu
    Copy the full SHA
    165849d View commit details
    Browse the repository at this point in the history

  2. Remove another redundant line 

    Co-authored-by: Arthur S. Muszynski <[email protected]>
    @juliohq @artism90
    juliohq and artism90 authored Sep 4, 2023
    Configuration menu
    Copy the full SHA
    7482cf7 View commit details
    Browse the repository at this point in the history

  3. Move ensure_connected and ensure_disconnected functions

    @juliohq
    juliohq committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    088a3dd View commit details
    Browse the repository at this point in the history