Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add second param to template handler #12

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

emp823
Copy link
Contributor

@emp823 emp823 commented Mar 7, 2020

Addresses #8

DEPRECATION WARNING: Single arity template handlers are deprecated. Template handlers must
now accept two parameters, the view object and the source for the view object.
Change:
  >> Caracal::Rails::TemplateHandler.call(template)
To:
  >> Caracal::Rails::TemplateHandler.call(template, source)

@anoobbava
Copy link

@carsonbaker , Could you please update if there is any possibility of merging this PR to the master. I am having the same issue when upgrading to Rails 6.

@carsonbaker
Copy link

@anoobbava I also wish it would merge, but I'm not the maintainer.

@jdugan
Copy link
Contributor

jdugan commented Jul 15, 2020

Hi, gents. Apologies for dropping the ball here. Caracal is well outside my day-to-day life now...and has been for many years, truthfully. Caracal was created for a company I worked for a decade ago and is now under the account of a different company with whom I have only a passing relationship. So, I'm the maintainer...but I'm also in kind of weird position. 🤷‍♂️

In any event, this change obviously looks fine. Because this is so small and appears to be wholly backward-compatible, I'm inclined to treat the change as a patch in terms of semantic versioning. Does that sound right to everyone else?

@emp823
Copy link
Contributor Author

emp823 commented Jul 15, 2020

Hi, gents. Apologies for dropping the ball here. Caracal is well outside my day-to-day life now...and has been for many years, truthfully. Caracal was created for a company I worked for a decade ago and is now under the account of a different company with whom I have only a passing relationship. So, I'm the maintainer...but I'm also in kind of weird position. 🤷‍♂️

In any event, this change obviously looks fine. Because this is so small and appears to be wholly backward-compatible, I'm inclined to treat the change as a patch in terms of semantic versioning. Does that sound right to everyone else?

Works for me, thanks.

@jdugan jdugan merged commit 0ad3a08 into urvin-compliance:master Jul 15, 2020
@jdugan
Copy link
Contributor

jdugan commented Jul 15, 2020

caracal-rails v1.0.2 is now available from rubygems. :)

@anoobbava
Copy link

Thanks @jdugan 👍 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants