Add Fabian Eckermann ns-3 c-v2x model into cdasim ns3_installer #155
Conversation
ns3::QueueBase::MaxPackets is not able to be configured when using Fabina Eckermann ns-3 simulation
| @@ -45,8 +45,8 @@ arg_federate_file="" | |||
| arg_integration_testing=false | |||
| arg_make_parallel="" | |||
|
|
|||
| required_programs=( python3.6 gcc unzip tar ) | |||
| required_libraries=( "libprotobuf-dev (or equal) 3.3.0" "libxml2-dev (or equal)" "libsqlite3-dev (or equal)" ) | |||
| required_programs=(python3.6 gcc unzip tar) | |||
There was a problem hiding this comment.
Did you run this file through an auto-formatter or something? Some of these changes are slightly odd, like deleting single spaces, removing semicolons where there were previously used but not strictly necessary. It's not a bad thing, just makes the file a bit harder to review since it's more difficult to identify the meaningful changes when they're mixed in with a bunch of formatting updates.
There was a problem hiding this comment.
Apologies for the confusion; it appears my VSCode automatically ran a formatting program. The modifications to the ns3_installer.sh file primarily concern the functions clone_ns3_federate, clone_ns3_cv2x, and build_ns3. If you think that is still hard to review, I can revert it and push the change again.
| ns3_url="http://www.nsnam.org/release/$ns3_version_affix.tar.bz2" | ||
| ns3_cv2x="https://github.com/usdot-fhwa-stol/ns-3_c-v2x" |
There was a problem hiding this comment.
I take it you resolved whatever issue there was with pulling this repo into the build?
There was a problem hiding this comment.
Yes, the issue has been addressed. The problem with ns3_cv2x I referenced earlier because I modified this line in the waf file of ns-3_c-v2x from #!/usr/bin/env python to #!/usr/bin/python3.6. However, making this change and then pushing it to GitHub disrupted other parts of the waf file. As a result, I've opted to update the build command here to include python version rather than altering the waf file directly.
|
|
||
| mkdir "${ns3_installation_path}/ns-allinone-${ns3_version}" | ||
|
|
||
| clone_ns3_cv2x |
There was a problem hiding this comment.
Have you confirmed that the folders these are getting cloned into is picked up in the build? Like seeing the fabian-eckermann build output?
There was a problem hiding this comment.
Yes, the cloned folders are picked up in the build. the build output can be seen during the docker image build process and Fabian Eckermann LTE lib can be found in lib folder after the build
| @@ -74,7 +74,7 @@ | |||
| <default name="ns3::ConstantRateWifiManager::DataMode" value="OfdmRate6Mbps"/> | |||
| <default name="ns3::ConstantRateWifiManager::ControlMode" value="OfdmRate6Mbps"/> | |||
|
|
|||
| <default name="ns3::QueueBase::MaxPackets" value="400"/> | |||
| <!-- <default name="ns3::QueueBase::MaxPackets" value="400"/> --> | |||
There was a problem hiding this comment.
I'd recommend adding a comment above that describes why we've removed this parameter for now.
docker/install.sh
Outdated
| @@ -113,6 +113,8 @@ cd "/opt/carma-simulation/bin/fed/ns3/" | |||
| chmod +x ns3_installer.sh | |||
| set -x | |||
| ./ns3_installer.sh -q | |||
|
|
|||
| # | |||
There was a problem hiding this comment.
Is there a reason for this blank comment?
|
Kudos, SonarCloud Quality Gate passed!
|
PR Details
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist:
CARMA Contributing Guide