Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null pointer when infrastructure registration includes no sensor registrations #158

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Fix null pointer when infrastructure registration includes no sensor registrations #158

merged 2 commits into from
Sep 13, 2023

Conversation

paulbourelly999
Copy link
Contributor

PR Details

Description

InfrastructureMessageAmbassador throws nullpointer exception when infrastructure registration message includes no sensor registrations. This PR addresses that and addresses some sonar code smells about logger calls

Related Issue

Motivation and Context

Fix null pointer

How Has This Been Tested?

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    CARMA Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@paulbourelly999 paulbourelly999 marked this pull request as ready for review September 11, 2023 19:46
@sonarcloud
Copy link

sonarcloud bot commented Sep 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@paulbourelly999 paulbourelly999 merged commit 5b61aa9 into develop Sep 13, 2023
6 checks passed
@paulbourelly999 paulbourelly999 deleted the fix_infrastructure_ambassador_null_pointer branch September 13, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricChen-Lei EricChen-Lei EricChen-Lei approved these changes

@kjrush kjrush Awaiting requested review from kjrush

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulbourelly999 @EricChen-Lei