Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Columbus Day as state holiday in California #1500

Closed
wants to merge 2 commits into from
+3 −2
Closed

Remove Columbus Day as state holiday in California #1500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b0b9e5
Remove columbus day as state holiday in California
hissingpanda Oct 5, 2023
3cc3ae6
add exemption for CA in columbus day US tests
hissingpanda Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions holidays/countries/united_states.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ def _add_subdiv_holidays(self):
if self._year >= 1937 and self.subdiv not in {
"AK",
"AR",
"CA",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read it as like the Columbus day holiday never existed. As far as I remember it was just renamed somewhere around 2019th. Please confirm with refs to some sources if possible.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were removed altogether in 2009 for CA and DE.

DC, ME, NM, and VT on the other hand kept it with a name change to "Indigenous Peoples' Day" in 2019.

Though if we're at it, may as well go deep down and check other cases as well like Hawaii's names change to "Discoverers Day" sometime prior to 2000 and other instances just to be sure. 👀

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were removed altogether in 2009 for CA and DE.

Any sources?

Also https://www.gov.ca.gov/2019/10/14/governor-newsom-issues-proclamation-declaring-indigenous-peoples-day/

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.pewresearch.org/short-reads/2023/10/05/working-on-columbus-day-or-indigenous-peoples-day-it-depends-on-where-your-job-is/

AFAIK California's Indigenous Peoples' Day declared in 2019 is an observed-only (no public holidays are given) https://en.m.wikipedia.org/wiki/Indigenous_Peoples%27_Day_(United_States)

Copy link
Author

@hissingpanda hissingpanda Oct 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right it should be only removed since 2009 not before so should update the PR for that. Here are some news article sources at least and the state holiday calendar. Native American Day on the fourth friday of september was added in lieu of it but also seems to be an optional day off that only some state institutions observe. Whereas the proclamation didn't make Indigenous Peoples' Day a holiday.

https://www.latimes.com/nation/nationnow/la-na-nn-columbus-day-why-do-we-still-celebrate-20151012-htmlstory.html

(Although California Gov. Arnold Schwarzenegger eliminated the Columbus Day state holiday as part of a budget-cutting measure in 2009, Los Angeles city and county offices still observe it. The Los Angeles Unified School District does not.)

https://www.pewresearch.org/short-reads/2023/10/05/working-on-columbus-day-or-indigenous-peoples-day-it-depends-on-where-your-job-is/

California, for example, is among the 26 states that don’t have an official public holiday on the second Monday in October. But in the past, it has designated the day as Indigenous Peoples’ Day by gubernatorial proclamation. California law also designates the fourth Friday in September as Native American Day, which state employees may take in lieu of their annual personal holiday.

"DE",
"FL",
"HI",
Expand Down
4 changes: 2 additions & 2 deletions tests/countries/test_united_states.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ def test_columbus_day(self):
)
self.assertHolidayName(name, dt)

subdiv_dont = {"AK", "AR", "DE", "FL", "HI", "NV", "SD", "VI"}
subdiv_dont = {"AK", "AR", "CA", "DE", "FL", "HI", "NV", "SD", "VI"}
for subdiv in set(UnitedStates.subdivisions) - subdiv_dont:
self.assertHolidayName(name, self.state_hols[subdiv], dt)

Expand All @@ -470,7 +470,7 @@ def test_columbus_day_states(self):
"2023-10-09",
)

for subdiv in ("AK", "AR", "DE", "FL", "HI", "NV"):
for subdiv in ("AK", "AR", "CA", "DE", "FL", "HI", "NV"):
self.assertNoHoliday(self.state_hols[subdiv], dt)
self.assertNoHolidayName(name, self.state_hols[subdiv])

Expand Down