Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Columbus Day as state holiday in California #1500

Closed
wants to merge 2 commits into from

Conversation

hissingpanda
Copy link

@hissingpanda hissingpanda commented Oct 5, 2023

Proposed change

Columbus day is no longer a state holiday in CA: https://www.sos.ca.gov/state-holidays

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've added references to all holidays information sources used in this PR
  • This PR is filed against beta branch of the repository
  • This PR doesn't contain any merge conflicts and has clean commit history
  • The code style looks good: make pre-commit command generates no changes
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
  • The related documentation has been added/updated (check off the box for free if no updates is required)

@PPsyrius
Copy link
Collaborator

PPsyrius commented Oct 6, 2023

From a quick check, looks like Delaware (DE) shouldn't have this too from 2009 onwards, with namechanges for the test mentioned here:

Since then, several states have moved away from Columbus Day. California and Delaware dropped the holiday entirely in 2009, the latter swapping in a floating holiday for state workers. Maine, New Mexico, Vermont and D.C. all renamed the day Indigenous Peoples’ Day in 2019, while retaining it as an official holiday.

@hissingpanda
Copy link
Author

hissingpanda commented Oct 6, 2023

Looks like Delaware is already excluded from it, thankfully. Just pushed some updates to exclude CA from the US columbus day tests, so hopefully that's all for this one.

KJhellico
KJhellico previously approved these changes Oct 6, 2023
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is LGTM. However, according to given sources, Columbus Day is no longer observed in a significant number of states, not just California. I will try to implement this in a separate PR.

@KJhellico KJhellico changed the title Remove columbus day as state holiday in California Remove Columbus Day as state holiday in California Oct 6, 2023
@arkid15r
Copy link
Collaborator

arkid15r commented Oct 6, 2023

PR is LGTM.

I'm not sure if the implementation is correct. Shouldn't we add a branching for the point in time when the holiday was removed and preserve history for previous years?

@KJhellico KJhellico self-requested a review October 6, 2023 16:42
@KJhellico KJhellico dismissed their stale review October 6, 2023 16:50

No need to delete the holiday entirely for CA

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hissingpanda, thanks for the PR!

The change you're proposing needs some clarification. Please share the information you used for making your decision to remove the holiday.

Thank you!

@@ -186,6 +186,7 @@ def _add_subdiv_holidays(self):
if self._year >= 1937 and self.subdiv not in {
"AK",
"AR",
"CA",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read it as like the Columbus day holiday never existed. As far as I remember it was just renamed somewhere around 2019th. Please confirm with refs to some sources if possible.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were removed altogether in 2009 for CA and DE.

DC, ME, NM, and VT on the other hand kept it with a name change to "Indigenous Peoples' Day" in 2019.

Though if we're at it, may as well go deep down and check other cases as well like Hawaii's names change to "Discoverers Day" sometime prior to 2000 and other instances just to be sure. 👀

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were removed altogether in 2009 for CA and DE.

Any sources?

Also https://www.gov.ca.gov/2019/10/14/governor-newsom-issues-proclamation-declaring-indigenous-peoples-day/

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

@hissingpanda hissingpanda Oct 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right it should be only removed since 2009 not before so should update the PR for that. Here are some news article sources at least and the state holiday calendar. Native American Day on the fourth friday of september was added in lieu of it but also seems to be an optional day off that only some state institutions observe. Whereas the proclamation didn't make Indigenous Peoples' Day a holiday.

https://www.latimes.com/nation/nationnow/la-na-nn-columbus-day-why-do-we-still-celebrate-20151012-htmlstory.html

(Although California Gov. Arnold Schwarzenegger eliminated the Columbus Day state holiday as part of a budget-cutting measure in 2009, Los Angeles city and county offices still observe it. The Los Angeles Unified School District does not.)

https://www.pewresearch.org/short-reads/2023/10/05/working-on-columbus-day-or-indigenous-peoples-day-it-depends-on-where-your-job-is/

California, for example, is among the 26 states that don’t have an official public holiday on the second Monday in October. But in the past, it has designated the day as Indigenous Peoples’ Day by gubernatorial proclamation. California law also designates the fourth Friday in September as Native American Day, which state employees may take in lieu of their annual personal holiday.

@KJhellico
Copy link
Collaborator

@hissingpanda, thank you for raising the issue of this nuanced holiday and providing valuable sources. I've made complex PR that addresses this more completely, not just for CA, so I'm going to close this PR. Please feel free to submit any questions or comments in #1503.

@KJhellico KJhellico closed this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants