-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Columbus Day as state holiday in California #1500
Conversation
No longer a state holiday in CA: https://www.sos.ca.gov/state-holidays
From a quick check, looks like Delaware (DE) shouldn't have this too from 2009 onwards, with namechanges for the test mentioned here:
|
Looks like Delaware is already excluded from it, thankfully. Just pushed some updates to exclude CA from the US columbus day tests, so hopefully that's all for this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR is LGTM. However, according to given sources, Columbus Day is no longer observed in a significant number of states, not just California. I will try to implement this in a separate PR.
I'm not sure if the implementation is correct. Shouldn't we add a branching for the point in time when the holiday was removed and preserve history for previous years? |
No need to delete the holiday entirely for CA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hissingpanda, thanks for the PR!
The change you're proposing needs some clarification. Please share the information you used for making your decision to remove the holiday.
Thank you!
@@ -186,6 +186,7 @@ def _add_subdiv_holidays(self): | |||
if self._year >= 1937 and self.subdiv not in { | |||
"AK", | |||
"AR", | |||
"CA", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read it as like the Columbus day holiday never existed. As far as I remember it was just renamed somewhere around 2019th. Please confirm with refs to some sources if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They were removed altogether in 2009 for CA
and DE
.
DC
, ME
, NM
, and VT
on the other hand kept it with a name change to "Indigenous Peoples' Day" in 2019.
Though if we're at it, may as well go deep down and check other cases as well like Hawaii's names change to "Discoverers Day" sometime prior to 2000 and other instances just to be sure. 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They were removed altogether in 2009 for
CA
andDE
.
Any sources?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK California's Indigenous Peoples' Day declared in 2019 is an observed-only (no public holidays are given) https://en.m.wikipedia.org/wiki/Indigenous_Peoples%27_Day_(United_States)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right it should be only removed since 2009 not before so should update the PR for that. Here are some news article sources at least and the state holiday calendar. Native American Day on the fourth friday of september was added in lieu of it but also seems to be an optional day off that only some state institutions observe. Whereas the proclamation didn't make Indigenous Peoples' Day a holiday.
(Although California Gov. Arnold Schwarzenegger eliminated the Columbus Day state holiday as part of a budget-cutting measure in 2009, Los Angeles city and county offices still observe it. The Los Angeles Unified School District does not.)
California, for example, is among the 26 states that don’t have an official public holiday on the second Monday in October. But in the past, it has designated the day as Indigenous Peoples’ Day by gubernatorial proclamation. California law also designates the fourth Friday in September as Native American Day, which state employees may take in lieu of their annual personal holiday.
- And here for the current year and previous you can see it's not on the state calendar: https://www.calhr.ca.gov/employees/pages/state-holidays.aspx
- State holidays in 2010: https://web.archive.org/web/20100209075521/http://www.dpa.ca.gov/personnel-policies/holidays.htm
- 2008 shows it as a state holiday whereas 2009 doesn't: https://web.archive.org/web/20080831103521/http://www.dpa.ca.gov/personnel-policies/holidays.htm
@hissingpanda, thank you for raising the issue of this nuanced holiday and providing valuable sources. I've made complex PR that addresses this more completely, not just for CA, so I'm going to close this PR. Please feel free to submit any questions or comments in #1503. |
Proposed change
Columbus day is no longer a state holiday in CA: https://www.sos.ca.gov/state-holidays
Type of change
Checklist
beta
branch of the repositorymake pre-commit
command generates no changesmake test
,make tox
(we strongly encourage adding tests to your code)