-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update United States holidays: Columbus Day adjustment #1503
Conversation
@PPsyrius , @hissingpanda, I'd be glad to see your thoughts. |
Pull Request Test Coverage Report for Build 6441311846
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Some minor comments:
Update: Seems like Minnesota (MN) just announced the change too yesterday (2023-10-09): https://www.wdio.com/front-page/top-stories/october-9th-is-officially-indigenous-peoples-day-in-minnesota/ |
As I understand, governor's proclamation is not enough to make it a legal state holiday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please make sure the CA Columbus Day PR doesn't become dangling due to this overhaul.
This PR includes changes from #1500 (remove Columbus Day for CA). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Proposed change
Columbus Day adjustment:
Type of change
Checklist
make pre-commit
command generates no changesmake test
,make tox
(we strongly encourage adding tests to your code)