Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update United States holidays: Columbus Day adjustment #1503

Merged
merged 6 commits into from
Oct 12, 2023

Conversation

KJhellico
Copy link
Collaborator

@KJhellico KJhellico commented Oct 7, 2023

Proposed change

Columbus Day adjustment:

  • Columbus Day with this exact name now exist only in 16 states and the territory of American Samoa
  • some states have this holiday as "Indigenous Peoples Day" or other name

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've added references to all holidays information sources used in this PR
  • The code style looks good: make pre-commit command generates no changes
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)

@KJhellico KJhellico requested a review from arkid15r as a code owner October 7, 2023 12:57
@KJhellico
Copy link
Collaborator Author

@PPsyrius , @hissingpanda, I'd be glad to see your thoughts.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6441311846

  • 28 of 28 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 6435590966: 0.0%
Covered Lines: 9560
Relevant Lines: 9560

💛 - Coveralls

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Some minor comments:

holidays/countries/united_states.py Outdated Show resolved Hide resolved
holidays/countries/united_states.py Outdated Show resolved Hide resolved
holidays/countries/united_states.py Outdated Show resolved Hide resolved
@PPsyrius
Copy link
Collaborator

Update: Seems like Minnesota (MN) just announced the change too yesterday (2023-10-09): https://www.wdio.com/front-page/top-stories/october-9th-is-officially-indigenous-peoples-day-in-minnesota/

@KJhellico
Copy link
Collaborator Author

Update: Seems like Minnesota (MN) just announced the change too yesterday (2023-10-09): https://www.wdio.com/front-page/top-stories/october-9th-is-officially-indigenous-peoples-day-in-minnesota/

As I understand, governor's proclamation is not enough to make it a legal state holiday.

arkid15r
arkid15r previously approved these changes Oct 11, 2023
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please make sure the CA Columbus Day PR doesn't become dangling due to this overhaul.

@KJhellico
Copy link
Collaborator Author

This PR includes changes from #1500 (remove Columbus Day for CA).

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@arkid15r arkid15r added this pull request to the merge queue Oct 12, 2023
Merged via the queue into vacanza:beta with commit 6e03890 Oct 12, 2023
22 checks passed
@KJhellico KJhellico deleted the upd-us-columbus-day branch October 16, 2023 15:23
@KJhellico KJhellico mentioned this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants