Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update South Korea holidays: 2025 temporary public holidays #2218

Merged
merged 5 commits into from
Jan 8, 2025

Conversation

YiGeon
Copy link
Contributor

@YiGeon YiGeon commented Jan 8, 2025

Add South Korea's temporary public holidays to January 27th, 2025.

Proposed change

Your PR description goes here.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

Add South Korea's temporary public holidays to January 27th, 2025.
@YiGeon YiGeon changed the title Add South Korea's temporary public holidays Update South Korea holidays: 2025 temporary public holidays Jan 8, 2025
@github-actions github-actions bot added the test label Jan 8, 2025
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

holidays/countries/south_korea.py Outdated Show resolved Hide resolved
holidays/countries/south_korea.py Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Jan 8, 2025

@YiGeon YiGeon requested a review from arkid15r January 8, 2025 02:30
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

holidays/countries/south_korea.py Show resolved Hide resolved
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f5f00ab) to head (66ed363).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2218   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          196       196           
  Lines        11828     11828           
  Branches      1707      1707           
=========================================
  Hits         11828     11828           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkid15r arkid15r enabled auto-merge January 8, 2025 02:52
Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🇰🇷

@YiGeon YiGeon requested a review from arkid15r January 8, 2025 02:55
@arkid15r arkid15r added this pull request to the merge queue Jan 8, 2025
Merged via the queue into vacanza:dev with commit 288ffad Jan 8, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants